Skip to content

PYTHONSTARTUP is not injected when terminal env experiment is off #25013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anthonykim1 opened this issue Apr 25, 2025 · 0 comments · Fixed by #25037
Closed

PYTHONSTARTUP is not injected when terminal env experiment is off #25013

anthonykim1 opened this issue Apr 25, 2025 · 0 comments · Fixed by #25037
Assignees
@anthonykim1
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug
Milestone
May 2025

Comments

@anthonykim1
Copy link

anthonykim1 commented Apr 25, 2025 •
edited
Loading

When terminal env experiment is off , PYTHONSTARTUP seems to be not injected, which is a bug.
Shell integration for python should work depending on the setting regardless of any other setting or experiment other than upstream terminal shell integration setting.

Update: It was getting injected, but was just getting cleared as part of check:

  • We clear env var collection when user isn't in env var experiment to get rid of stale env var.
@anthonykim1 anthonykim1 added the feature-request Request for new features or functionality label Apr 25, 2025
@anthonykim1 anthonykim1 self-assigned this Apr 25, 2025
@anthonykim1 anthonykim1 added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Apr 25, 2025
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Apr 25, 2025
@anthonykim1 anthonykim1 added area-terminal and removed triage-needed Needs assignment to the proper sub-team labels Apr 25, 2025
@anthonykim1 anthonykim1 mentioned this issue Apr 25, 2025
Closed
@anthonykim1 anthonykim1 added this to the May 2025 milestone May 5, 2025
@anthonykim1 anthonykim1 mentioned this issue May 5, 2025
Merged
anthonykim1 added a commit that referenced this issue May 6, 2025
@anthonykim1
PYTHONSTARTUP should be injected regardless of terminalEnv experiment (…
0317c6b 
…#25037)

Resolve: #25013 

Python shell integration env var injection via env var collection was
getting cleared undesirable, when user had opted out of terminal env var
experiment.

We want to inject PYTHONSTARTUP regardless of the experiment, depending
on user setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonykim1 anthonykim1

Labels
area-terminal bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
May 2025
Development

Successfully merging a pull request may close this issue.

PYTHONSTARTUP should be injected regardless of terminalEnv experiment anthonykim1/vscode-python
1 participant
@anthonykim1