Fetching pull requests failed: TypeError: Cannot read property 'link' of undefined

[alexdima]

I'm just trying to look at PRs assigned to me, but they don't come up. It is weird, because this worked for me on the mac with an older version of the extension...

[rebornix]

@RMacfarlane this is where we access link https://github.com/Microsoft/vscode-pull-request-github/blob/master/src/github/githubRepository.ts#L36 , is it possible that headers is undefined?

[RMacfarlane]

@alexandrudima I think different versions of the @octokit\rest package are being installed based on using npm vs yarn. When using yarn, "^15.2.6" is resolving to that exact version on my machine, and using npm results in 15.8.1 being installed. Between those versions, the property "meta" was renamed to "headers" on the response object. So there should always be a headers property if the request succeeded.

I'll bump the version in the package.json to 15.8.0, the version that introduced the rename

[alexdima]

Oh yeah, I manually ran yarn on that folder because I had some dugite trouble on Windows. Will try with the new vsix 👍

EDIT: This works fine now, closing.