Skip to content

Clicking on a file in a commit with outdated comments fails #2697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alexr00 opened this issue Apr 29, 2021 · 0 comments · Fixed by #2698
Closed

Clicking on a file in a commit with outdated comments fails #2697

alexr00 opened this issue Apr 29, 2021 · 0 comments · Fixed by #2698
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
April 2021

Comments

@alexr00
Copy link
Member

alexr00 commented Apr 29, 2021

  1. Open a clone of microsoft/vscode
  2. Checkout this PR: Initial implementation of drag and drop api vscode#122239
  3. In the Commits section of the Changes view, expand the commit "address pr comments"
  4. Click on vscode.proposed.d.ts
  5. Nothing appears to happen. If you open the dev tools you'll see an error.
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Apr 29, 2021
@alexr00 alexr00 added this to the April 2021 milestone Apr 29, 2021
@alexr00 alexr00 self-assigned this Apr 29, 2021
alexr00 added a commit that referenced this issue Apr 29, 2021
@alexr00
Clicking on a file in a commit with outdated comments fails
9d1dc80 
Fixes #2697
@alexr00 alexr00 mentioned this issue Apr 29, 2021
Merged
alexr00 added a commit that referenced this issue Apr 30, 2021
@alexr00
Clicking on a file in a commit with outdated comments fails
a7202ad 
Fixes #2697
alexr00 added a commit that referenced this issue Apr 30, 2021
@alexr00
Clicking on a file in a commit with outdated comments fails (#2698)
84d1d9d 
Fixes #2697
@rzhao271 rzhao271 added the verified Verification succeeded label Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

Successfully merging a pull request may close this issue.

Clicking on a file in a commit with outdated comments fails microsoft/vscode-pull-request-github
2 participants
@rzhao271 @alexr00