This repository was archived by the owner on Mar 3, 2025. It is now read-only.
Refactor pylance reusable pieces to only depend upon protocol types #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
Dec 7, 2021
| @@ -2,8 +2,8 @@ | |||
| // Licensed under the MIT License. | |||
|
|
|||
| 'use strict'; | |||
| import * as vscode from 'vscode'; | |||
| import * as protocol from 'vscode-languageclient/node'; | |||
| import * as vscodeUri from 'vscode-uri'; | |||
There was a problem hiding this comment.
@heejaechang @bschnurr this file should now be not using any of the vscode types.
rchiodo
commented
Dec 7, 2021
| @@ -0,0 +1,952 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
| // Licensed under the MIT License. | |||
| import * as os from 'os'; | |||
There was a problem hiding this comment.
Same with this file. Should be vscode free.
bschnurr
reviewed
Dec 7, 2021
| import * as vscode from 'vscode'; | ||
| import * as protocol from 'vscode-languageclient/node'; | ||
| import * as vscodeUri from 'vscode-uri'; | ||
| import * as protocol from 'vscode-languageclient'; |
There was a problem hiding this comment.
Not sure if it helps but we get all the types for TextDocument, Range, Position from vscode-languageserver-types lib
There was a problem hiding this comment.
Oh thanks. I'll try that and see what happens. Should be the same I think.
There was a problem hiding this comment.
Didn't work, but 'vscode-languageserver-protocol' seems to work. I'll switch to that one.
DonJayamanne
approved these changes
Dec 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For microsoft/vscode-jupyter#8467