Skip to content

Improve in-editor display #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pfitzseb opened this issue Jun 30, 2020 · 4 comments
Open

Improve in-editor display #10

pfitzseb opened this issue Jun 30, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@pfitzseb
Copy link

Currently, timings/number of ticks are displayed as code lenses:
image

Imho, this is slightly annoying because a) it moves your code around and b) it's hard to get a quick overview over which line in your code is expensive to execute.
I'd like to propose an alternative display mode that instead changes the line background color up to a width proportional to the amount of time spent on that line relative to the current frame's total time (Juno has that feature):
image

Ignore the drastically different results for now, I think our Julia -> .cpuprofile translation has a bug somewhere.

This is possible with the current decoration API, but might require padding the end of the line with spaces.

@connor4312 connor4312 self-assigned this Jul 1, 2020
@connor4312 connor4312 added the enhancement New feature or request label Jul 1, 2020
@carstenbauer
Copy link

+infinity for this one!!!

@davidanthoff
Copy link

Just a small bump for this, I tried to use our profiler the other day, and having this would be very welcome :)

@jeffreyesun
Copy link

jeffreyesun commented Sep 7, 2022

What's the status of this? As far as I can tell, timings aren't shown at all now, just ticks. And it is now no longer possible to view the self time/ticks of a function as opposed to the total time/ticks. Both pieces of data are important to report, in my opinion: consider a line like

g = f.(A).^2

The total time tells us how much time is spent executing f, whereas the self time tells us how much time is spent allocating the result vector and taking the power.

Possibly a separate issue, but the table view is also gone, which removes the other place in which self vs. total times could have been read.

Edit: As @pfitzseb rightly points out, I posted this in the wrong place. I was referring to the behavior of vscode for Julia (which stopped using this tool), not this visualization tool in general.

@pfitzseb
Copy link
Author

pfitzseb commented Sep 8, 2022

Note that the Julia extension is no longer using this package for visualization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants