Skip to content

fix: add json, jsonc to eslint.probe's default options #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Apr 15, 2024
Merged

fix: add json, jsonc to eslint.probe's default options #1830

merged 1 commit into from Apr 15, 2024

Conversation

hyoban
Copy link
Contributor

@hyoban hyoban commented Apr 12, 2024

fix #1829

@dbaeumer dbaeumer enabled auto-merge (squash) April 15, 2024 07:07
@vscodenpa vscodenpa added this to the April 2024 milestone Apr 15, 2024
@dbaeumer dbaeumer merged commit 553e632 into microsoft:main Apr 15, 2024
@davidkarlsson
Copy link

These new defaults doesn't seem to be documented for the eslint.probe setting in README.md.

The change caused a bit of confusion for me because vscode-eslint started showing a "No ESLint configuration found" error in 3.0.7 and above just because I happened to have a package.json file open from a project that shouldn't even have a eslint config because it's the root project of a yarn workspace.

@dbaeumer
Copy link
Member

dbaeumer commented Oct 7, 2024

Good catch. I updated the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default options for eslint.probe to include json, jsonc
5 participants