Settings documentation

[kocv59]

Documentation is missing default for some like eslint.quiet.

Settings like eslint.validate doesn't explain some values like what is on value. nvim lspconfig uses the on value.

[dbaeumer]

on is not a valid value for validate. From the doc

eslint.validate - an array of language identifiers specifying the files for which validation is to be enforced. If specified only files with one of the language Ids specified will be validated. This is comparable to the --ext command line option. Defaults to null.

[dbaeumer]

I fixed the eslint.quiet setting.

[kocv59]

It won't function properly without validate = "on". Here's how nvim-lspconfig handles it, and they reference this repository. https://github.com/neovim/nvim-lspconfig/blob/master/lsp/eslint.lua Do the settings on line 86 refer to vscode-eslint settings?

If you remove it or set it to {}, { "javascript" } or null, it doesn't capture any errors in a JavaScript file. However, setting validate = "on" captures the errors.

[kocv59]

@dbaeumer The link you provided in the other issue indicates that it indeed uses validate = "on". You can check the settings in the following file: https://github.com/microsoft/vscode-eslint/blob/main/%24shared/settings.ts. The documentation should be revised to accurately reflect these settings and their default values.

[dbaeumer]

@kocv59 the settings documentation is for VS Code users and what they should but into the settings.json file. The link in the other file is the internal settings implementation that is used to communicate between the client and the server. It doesn't 1:1 reflect the settings in the settings file.

[kocv59]

It's not internal because people using LSP use them to configure different editors so they should be documented. You could have a section for VS Code settings.json settings and settings needed for LSP users.