-
Notifications
You must be signed in to change notification settings - Fork 5k
Notebook docs #3807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebook docs #3807
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work and I like the flow a lot ❤️ . Only a couple of suggestions.
- text/x-javascript | ||
|
||
To render an alternative mimetype, a `NotebookOutputRenderer` must be registered for that mimetype. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may also want to talk about multi-mimetype output and how extensions and users can control the display order of multi-mimetype output.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave an example above with
{
outputKind: vscode.CellOutputKind.Rich,
data: {
'text/html': '<b>Hello</b> World',
'application/json': { hello: 'world' },
'application/hello-world': 'my-hello-world-data-interchange-format',
}
}
is that what you mean by multi-mimetype output?
And how can extensions and users can control the display order of multi-mimetype output?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's a multi-mimetype output. Firstly, we have builtin display orders
and both notebook content providers
and users ("notebook.displayOrder": []
) can control that. Also, users settings > document metadata > builtin orders.
Minor point but it sounds like maybe we should be using |
In the actual API I mean |
@roblourens that makes sense to me. Maybe open an issue in vscode? |
|
||
## Supporting Debugging | ||
For some kernels, such as those that implement a programming language, it can be desirable to allow debugging a cell's execution. To accomplish this, a notebook kernel can implement a [debug adapter](https://microsoft.github.io/debug-adapter-protocol/), either by directly implementing the protocol, or providing an interface between an existing notebook debugger and the protocol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think any kernel would be tied to a programming language. A provider might not be (markdown notebook etc) but I think any kernel would execute something right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some that execute HTTP requests..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh good point
cc @gregvanl or @ornellaalt :) |
@roblourens @JacksonKearl I'm wondering if |
Ok I guess we should stick with it if that's what is typically used |
Ref #3784