Skip to content

Icons to sort alphabetically vs sort by percent #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
connor4312 opened this issue Nov 27, 2023 · 3 comments · Fixed by #244
Closed

Icons to sort alphabetically vs sort by percent #210

connor4312 opened this issue Nov 27, 2023 · 3 comments · Fixed by #244
Assignees

Comments

@connor4312
Copy link
Member

Is your icon request related to a problem? Please describe.

In the test coverage view, I want to let users toggle whether files are sorted alphabetically or whether they're sorted by the coverage percent.

Describe the solution you'd like

Perhaps something along these lines with an alternative version that has AZ instead of %

https://www.iconfinder.com/icons/5014732/arrow_by_price_data_filter_percent_sort_up_icon

Describe alternatives you've considered

There aren't really sorting icons in our existing codicons

@hbons hbons self-assigned this Dec 5, 2023
@hbons
Copy link
Member

hbons commented Mar 25, 2024

Since lists in VS Code are usually sorted by alphabet by default, would it be a good idea to only add a "sort percent" button that becomes toggled on press?

@connor4312
Copy link
Member Author

Sure 👍

@hbons
Copy link
Member

hbons commented Mar 27, 2024

Adding percentage and sort-percentage. Keeping the metaphor simple, just a percent. For this case the context will be obvious.

image

hbons added a commit that referenced this issue Mar 27, 2024
@hbons hbons mentioned this issue Mar 27, 2024
hbons added a commit that referenced this issue Mar 27, 2024
hbons added a commit that referenced this issue Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants