Skip to content

Fix assembly resolution with DeploymentItem (#3034) #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024
Merged

Fix assembly resolution with DeploymentItem (#3034) #3036

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Adapter/MSTestAdapter.PlatformServices/Services/TestSourceHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,12 @@ public void SetupHost()
// which is trigged by AppContainerUtilities.AttachEventToResolveWinmd method.
EqtTrace.SetupRemoteEqtTraceListeners(AppDomain);

// Force loading Microsoft.TestPlatform.CoreUtilities in the new app domain to ensure there is no assembly resolution issue.
// For unknown reasons, with MSTest 3.4+ we start to see infinite cycles of assembly resolution of this dll in the new app
// domain. In older versions, this was not the case, and the callback was allowing to fully lookup and load the dll before
// triggering the next resolution.
AppDomain.Load(typeof(EqtTrace).Assembly.GetName());

// Add an assembly resolver in the child app-domain...
Type assemblyResolverType = typeof(AssemblyResolver);

Expand Down