Add 2 additional error messages #18462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional information to 3 error senarios when launching a different profile in the ConptyConnection. - Requires Elevation - CTRL+C - Bad Command or File Not Found closes microsoft#7186
|
@microsoft-github-policy-service agree |
microsoft-github-policy-service
bot
added
Issue-Task
This comment has been minimized.
This comment has been minimized.
- Removed BadCommand text - Added FileNotFound text
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
halldk
changed the title
microsoft-github-policy-service
bot
removed
the
Needs-Author-Feedback
|
@KalleOlaviNiemitalo are you able to review again? It's been a couple weeks. |
carlos-zamora
approved these changes
Feb 20, 2025
microsoft-github-policy-service
bot
requested review from
zadjii-msft,
PankajBhojwani,
carlos-zamora,
DHowett and
lhecker
PankajBhojwani
approved these changes
Feb 20, 2025
microsoft-github-policy-service
bot
removed
the
Needs-Second
DHowett
approved these changes
Mar 21, 2025
DHowett
approved these changes
Mar 21, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
It seems this PR fell off our radar. I apologize. |
carlos-zamora
approved these changes
Apr 14, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
DHowett
pushed a commit
that referenced
this pull request
Apr 21, 2025
Add additional information to 2 error scenarios when launching a different profile in the `ConptyConnection.cpp` file. - Requires Elevation - File Not Found Created a profile that required elevation and verified the error message. Created profile that passed a made up command and verified the error message. Closes #7186 (cherry picked from commit f7e853c) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgZlxJc Service-Version: 1.22
DHowett
pushed a commit
that referenced
this pull request
Apr 21, 2025
Add additional information to 2 error scenarios when launching a different profile in the `ConptyConnection.cpp` file. - Requires Elevation - File Not Found Created a profile that required elevation and verified the error message. Created profile that passed a made up command and verified the error message. Closes #7186 (cherry picked from commit f7e853c) Service-Card-Id: PVTI_lADOAF3p4s4AxadtzgZlxJY Service-Version: 1.23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional information to 2 error scenarios when launching a different profile in the
ConptyConnection.cppfile.Created a profile that required elevation and verified the error message. Created profile that passed a made up command and verified the error message. Unable to test CTRL+C case, but included due to issue conversation.
Closes #7186