[Enterprise, GPO] Add "Default Terminal app" policy to definition template

[htcfreek]

Summary of the Pull Request

This PR implements a policy definition for setting/enforcing the default terminal application.

References and Relevant Issues

GitHub (issues):

• Group Policy to control default Terminal setting #18302
• Group Policy to control default Terminal setting #18303

Docs:

• https://support.microsoft.com/en-us/windows/command-prompt-and-windows-powershell-for-windows-11-6453ce98-da91-476f-8651-5c14d5777c20
• Does Windows 10 support setting Terminal as the default console host? #13153 (comment)

Detailed Description of the Pull Request / Additional comments

This PR adds a new policy definition to the ADMX templates for settings the default Terminal application in Windows.

Note

This PR does not change any code of Windows, Console Host or WIndows Terminal. It only adds the definiton for a new policy to the templates.

I got the registry values form the documentation and by testing the values.

The policy is only available as user policy because the registry values have to be in HKCU.

The Policy is implemented as preference (not inside the Policy key) and therefore keeps it's value on removing (not configured) it. You can see this in gpedit.msc on the policy symbol and the hint in the description.

Validation Steps Performed

Manual testing the policy.

PR Checklist

• Closes Group Policy to control default Terminal setting #18302
• Tests added/passed
• Documentation updated
  • If checked, please file a pull request on our docs repo and link it here: [GroupPolicy docs] Add new "Default Terminal Application" policy MicrosoftDocs/terminal#823
• Schema updated (if necessary)

[htcfreek]

Can you please assign me.

[htcfreek]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 18363 in repo microsoft/terminal

[DHowett]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[DHowett]

So, this is technically a third-party extensibility point. Can the policy support a freeform GUID entry (or GUID pair entry, as it were) for any third party terminals that have onboarded?

[htcfreek]

So, this is technically a third-party extensibility point. Can the policy support a freeform GUID entry (or GUID pair entry, as it were) for any third party terminals that have onboarded?

@DHowett
I did some tests now and there are two options. Both solutions support default value(s).

But while testing I found a strange and uncool behavior: Even if I define a "disabledList", the values will be deleted in Registry if the policy is disabled. Is this a blocking problem for us? (I have tested that WT and Console won't crash.)

Solutions

1. Policy with drop-down that has fixed values.
   
2. Policy with two text boxes and well-known combinations listed in the description.
   

[DHowett]

Thanks for doing this! I understand your comments about the free entry field, I'll need to think about them for a bit. This is looking very good.

[htcfreek]

@DHowett
Any updates on this? What should we do with the PR?

[DHowett]

Alright, I thought about this for a while. Clearly, it has been a while.

We have no other 3p terminals that plug in to this mechanism.
Your solution of having the dropdown is, right now, more elegant and closer to product truth.

I think your original implementation was the right one.

Thank you so much for doing it, and for your patience. :)

[DHowett]

I reset your branch to the point in time before you did the freeform textbox work. :)

[htcfreek]

@DHowett
Who is able to finally approve and merge? PR is still blocked.

[DHowett]

Who is able to finally approve and merge? PR is still blocked.

I got pulled into a meeting before I could click the button :P

[DHowett]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[carlos-zamora]

Looks good. Thanks for doing this!

[htcfreek]

@DHowett , @carlos-zamora
What is the release version that will contain the updated templates? You can back port the PR to the next stable patch.

Btw, please don't forget the docs merge on release.

[DHowett]

What is the release version that will contain the updated templates?

I can't tell you that until I've minted the release (considering that it contains the day of the year in the version number.)

It'll be included with the next servicing updates.

Thanks for the reminder about docs.