Skip to content

[1.17] Setting app theme results in mismatched light/dark colors for SUI text #14559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
carlos-zamora opened this issue Dec 15, 2022 · 3 comments · Fixed by #14644
Closed

[1.17] Setting app theme results in mismatched light/dark colors for SUI text #14559

carlos-zamora opened this issue Dec 15, 2022 · 3 comments · Fixed by #14644
Assignees
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@carlos-zamora
Copy link
Member

Go to Appearance -> set theme to 'Light'

Some settings have the header in black some have them in white (seems to be the different setting container styles)
GetImage (3)

@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Area-SettingsUI Anything specific to the SUI labels Dec 15, 2022
@carlos-zamora carlos-zamora added this to the Terminal v1.17 milestone Dec 15, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 15, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 15, 2022
@zadjii-msft zadjii-msft self-assigned this Jan 4, 2023
@zadjii-msft
Copy link
Member

Hmm. I don't know if I can repro this exactly.

What I can repro is the SUI BG not matching the app theme. That I think regressed in #14567, which I can't remember if it made it to the bug bash or not.

Does this happen on launch when the theme is set to "light"? Or do you need to switch from some other theme?

I'll submit the mica fix, and then you try that out and tell me if this is gone

@ghost ghost added the In-PR This issue has a related PR label Jan 6, 2023
@carlos-zamora
Copy link
Member Author

Hmm. I don't know if I can repro this exactly.

What I can repro is the SUI BG not matching the app theme. That I think regressed in #14567, which I can't remember if it made it to the bug bash or not.

Does this happen on launch when the theme is set to "light"? Or do you need to switch from some other theme?

I'll submit the mica fix, and then you try that out and tell me if this is gone

The way I got it to repro was...

  1. OS theme = dark
  2. In Terminal, start with theme=terminal
  3. switch to theme=Light
        {
            "name": "terminal",
            "tab": 
            {
                "background": "terminalBackground",
                "showCloseButton": "always",
                "unfocusedBackground": null
            },
            "tabRow": 
            {
                "background": "terminalBackground",
                "unfocusedBackground": null
            },
            "window": 
            {
                "applicationTheme": "dark",
                "useMica": false
            }
        }

@ghost ghost closed this as completed in #14644 Jan 18, 2023
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 18, 2023
ghost pushed a commit that referenced this issue Jan 18, 2023
I can't exactly repro #14559. I suspect that's due to #14567 having been merged. This, however, seemed related. Without this, we'll use the App's `RequestedTheme` (the one that can't be changed at runtime), rather than the user's `requestedTheme`. That will do weird things, like make the BG of the SUI dark, with white expanders.

I think this should close #14559.
@ghost
Copy link

ghost commented Jan 24, 2023

🎉This issue was addressed in #14644, which has now been successfully released as Windows Terminal Preview v1.17.1023.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants