Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Fix bug in sqlite filter logic #11356

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

westey-m
Copy link
Contributor

@westey-m westey-m commented Apr 3, 2025

Motivation and Context

#11132

Description

Fix bug in sqlite filter logic

Contribution Checklist

@westey-m westey-m requested a review from a team as a code owner April 3, 2025 11:27
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Apr 3, 2025
@github-actions github-actions bot changed the title Fix bug in sqlite filter logic .Net: Fix bug in sqlite filter logic Apr 3, 2025
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @westey-m !

Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, my bad...

@westey-m westey-m enabled auto-merge April 3, 2025 13:48
@westey-m westey-m added this pull request to the merge queue Apr 3, 2025
Merged via the queue into microsoft:main with commit ecf5cba Apr 3, 2025
26 checks passed
@westey-m westey-m deleted the sqlite-filter-fix branch April 3, 2025 14:22
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this pull request Apr 6, 2025
### Motivation and Context

microsoft#11132

### Description

Fix bug in sqlite filter logic

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants