Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Move hybrid search tests to new projects and adopt updated software design. #11339

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

westey-m
Copy link
Contributor

@westey-m westey-m commented Apr 2, 2025

Motivation and Context

Some of the mongodb tests are failing intermittently. Moving to new design which has built in checks for making sure data is indexed before running test.

#11311

Description

Move hybrid search tests to new projects and adopt updated software design.

Contribution Checklist

@westey-m westey-m requested a review from a team as a code owner April 2, 2025 14:49
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Apr 2, 2025
@github-actions github-actions bot changed the title Move hybrid search tests to new projects and adopt updated software design. .Net: Move hybrid search tests to new projects and adopt updated software design. Apr 2, 2025
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for adding more conformance tests @westey-m !

@westey-m westey-m added this pull request to the merge queue Apr 2, 2025
Merged via the queue into microsoft:main with commit 5f8a56a Apr 2, 2025
20 checks passed
@westey-m westey-m deleted the hybrid-search-tests-new-design branch April 2, 2025 15:35
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this pull request Apr 6, 2025
…ware design. (microsoft#11339)

### Motivation and Context

Some of the mongodb tests are failing intermittently. Moving to new
design which has built in checks for making sure data is indexed before
running test.

microsoft#11311

### Description

Move hybrid search tests to new projects and adopt updated software
design.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants