Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Add date to obsolete messages for when to expect these methods to be deleted. #11329

Merged

Conversation

westey-m
Copy link
Contributor

@westey-m westey-m commented Apr 2, 2025

Motivation and Context

We should warm users of the timeframe at which obsoleted methods will be deleted.
#11315

Description

Add a date to the obsolete messages for obsolete methods on the agent implementations.

Contribution Checklist

@westey-m westey-m requested a review from a team as a code owner April 2, 2025 09:01
@markwallace-microsoft markwallace-microsoft added the .NET Issue or Pull requests regarding .NET code label Apr 2, 2025
@github-actions github-actions bot changed the title Add date to obsolete messages for when to expect these methods to be deleted. .Net: Add date to obsolete messages for when to expect these methods to be deleted. Apr 2, 2025
@westey-m westey-m enabled auto-merge April 2, 2025 16:24
@westey-m westey-m added this pull request to the merge queue Apr 2, 2025
Merged via the queue into microsoft:main with commit 0a94e61 Apr 2, 2025
22 checks passed
@westey-m westey-m deleted the common-agent-api-obsoletedeletedate branch April 2, 2025 18:15
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this pull request Apr 6, 2025
…to be deleted. (microsoft#11329)

### Motivation and Context

We should warm users of the timeframe at which obsoleted methods will be
deleted.
microsoft#11315 

### Description

Add a date to the obsolete messages for obsolete methods on the agent
implementations.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants