.Net: Refactor MCP client for improved code readability #11306
Merged
+70
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeyMenshykh
had a problem deploying
to
integration
GitHub Actions
Error
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
RogerBarreto
reviewed
Apr 1, 2025
dotnet/samples/Demos/ModelContextProtocolClientServer/MCPClient/Program.cs
Show resolved
Hide resolved
dotnet/samples/Demos/ModelContextProtocolClientServer/MCPClient/Program.cs
Outdated
Show resolved
Hide resolved
dotnet/samples/Demos/ModelContextProtocolClientServer/MCPClient/Program.cs
Outdated
Show resolved
Hide resolved
SergeyMenshykh
had a problem deploying
to
integration
GitHub Actions
Error
…enshykh/semantic-kernel into restructure-mcp-sample-1
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
westey-m
reviewed
Apr 1, 2025
dotnet/samples/Demos/ModelContextProtocolClientServer/MCPClient/Program.cs
Outdated
Show resolved
Hide resolved
westey-m
previously approved these changes
Apr 1, 2025
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
RogerBarreto
approved these changes
Apr 1, 2025
westey-m
approved these changes
Apr 1, 2025
eavanvalkenburg
pushed a commit
to eavanvalkenburg/semantic-kernel
that referenced
this pull request
Apr 2, 2025
glorious-beard
pushed a commit
to glorious-beard/semantic-kernel
that referenced
this pull request
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation, Context and Description
Refactor the MCPClient to improve code readability by moving details unrelated to MCP into private methods.