Python: Fix sample and README #11298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
python
moonbox3
added
agents
and removed
python
github-actions
bot
changed the title
markwallace-microsoft
added
python
TaoChenOSU
approved these changes
Apr 1, 2025
westey-m
approved these changes
Apr 2, 2025
eavanvalkenburg
pushed a commit
to eavanvalkenburg/semantic-kernel
that referenced
this pull request
Apr 2, 2025
### Motivation and Context The AzureAIAgent step1 sample is using a `thread_id` kwarg for `agent.invoke(...)`. Fix this to be `thread` instead, so we can use the created thread for later invokes. For the OpenAIAssistantAgent README, update the `thread` related items to use the new common agent invoke api constructs. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description Update a sample and a README. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
glorious-beard
pushed a commit
to glorious-beard/semantic-kernel
that referenced
this pull request
Apr 6, 2025
### Motivation and Context The AzureAIAgent step1 sample is using a `thread_id` kwarg for `agent.invoke(...)`. Fix this to be `thread` instead, so we can use the created thread for later invokes. For the OpenAIAssistantAgent README, update the `thread` related items to use the new common agent invoke api constructs. <!-- Thank you for your contribution to the semantic-kernel repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> ### Description Update a sample and a README. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [X] The code builds clean without any errors or warnings - [X] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [X] All unit tests pass, and I have added new tests where possible - [X] I didn't break anyone 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The AzureAIAgent step1 sample is using a
thread_idkwarg foragent.invoke(...). Fix this to bethreadinstead, so we can use the created thread for later invokes.For the OpenAIAssistantAgent README, update the
threadrelated items to use the new common agent invoke api constructs.Description
Update a sample and a README.
Contribution Checklist