-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net: Removing KernelAgent.cs and moving its functionality into Agent.cs #11244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westey-m
previously approved these changes
Mar 28, 2025
TaoChenOSU
previously approved these changes
Mar 28, 2025
markwallace-microsoft
previously approved these changes
Apr 1, 2025
westey-m
reviewed
Apr 1, 2025
westey-m
previously approved these changes
Apr 1, 2025
53e94ff
alliscode
commented
Apr 1, 2025
westey-m
reviewed
Apr 1, 2025
westey-m
previously approved these changes
Apr 1, 2025
markwallace-microsoft
previously approved these changes
Apr 1, 2025
shethaadit
approved these changes
Apr 1, 2025
a5fafe1
westey-m
approved these changes
Apr 1, 2025
crickman
approved these changes
Apr 1, 2025
glorious-beard
pushed a commit
to glorious-beard/semantic-kernel
that referenced
this pull request
Apr 6, 2025
….cs (microsoft#11244) ### Description Removing `KernelAgent` to decrease the number of layers in the Agent Framework. - Moved functionality of `KernelAgent` to `Agent` - Moved tests from `KernelAgentTests` to `AgentTests` - Removed `KernelAgent` and `KernelAgentTests` - Renamed `ChatHistoryKernelAgent` to `ChatHistoryAgent` ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Ben Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing
KernelAgent
to decrease the number of layers in the Agent Framework.KernelAgent
toAgent
KernelAgentTests
toAgentTests
KernelAgent
andKernelAgentTests
ChatHistoryKernelAgent
toChatHistoryAgent
Contribution Checklist