Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.Net: Removing KernelAgent.cs and moving its functionality into Agent.cs #11244

Merged
merged 9 commits into from
Apr 2, 2025

Conversation

alliscode
Copy link
Member

Description

Removing KernelAgent to decrease the number of layers in the Agent Framework.

  • Moved functionality of KernelAgent to Agent
  • Moved tests from KernelAgentTests to AgentTests
  • Removed KernelAgent and KernelAgentTests
  • Renamed ChatHistoryKernelAgent to ChatHistoryAgent

Contribution Checklist

@alliscode alliscode requested a review from a team as a code owner March 27, 2025 23:22
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Mar 27, 2025
@github-actions github-actions bot changed the title Removing KernelAgent.cs and moving its functionality into Agent.cs .Net: Removing KernelAgent.cs and moving its functionality into Agent.cs Mar 27, 2025
westey-m
westey-m previously approved these changes Mar 28, 2025
TaoChenOSU
TaoChenOSU previously approved these changes Mar 28, 2025
@alliscode alliscode dismissed stale reviews from TaoChenOSU and westey-m via 03d9c53 April 1, 2025 00:46
westey-m
westey-m previously approved these changes Apr 1, 2025
westey-m
westey-m previously approved these changes Apr 1, 2025
@crickman crickman added this pull request to the merge queue Apr 1, 2025
@crickman crickman removed this pull request from the merge queue due to a manual request Apr 1, 2025
@alliscode alliscode added this pull request to the merge queue Apr 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 2, 2025
@alliscode alliscode added this pull request to the merge queue Apr 2, 2025
Merged via the queue into microsoft:main with commit 44370f9 Apr 2, 2025
20 checks passed
@alliscode alliscode deleted the remove-kernel-agent branch April 2, 2025 15:31
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this pull request Apr 6, 2025
….cs (microsoft#11244)

### Description

Removing `KernelAgent` to decrease the number of layers in the Agent
Framework.

- Moved functionality of `KernelAgent` to `Agent`
- Moved tests from `KernelAgentTests` to `AgentTests`
- Removed `KernelAgent` and `KernelAgentTests`
- Renamed `ChatHistoryKernelAgent` to `ChatHistoryAgent`

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Ben Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants