Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Refactored IsFilterable to IsIndexed for MEVD. #11167

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

.Net: Refactored IsFilterable to IsIndexed for MEVD. #11167

wants to merge 6 commits into from

Conversation

shethaadit
Copy link
Contributor

Refactored IsFilterable to IsIndexed for MEVD.

Fixes #11130

@shethaadit shethaadit requested a review from a team as a code owner March 24, 2025 20:55
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel memory labels Mar 24, 2025
@github-actions github-actions bot changed the title Refactored IsFilterable to IsIndexed for MEVD. .Net: Refactored IsFilterable to IsIndexed for MEVD. Mar 24, 2025
@shethaadit shethaadit mentioned this pull request Mar 24, 2025
Open
@shethaadit
Copy link
Contributor Author

Hi @markwallace-microsoft, could you please help reviewing this PR?

@shethaadit
Copy link
Contributor Author

Hi @markwallace-microsoft, could you please help reviewing this PR?

Hi @markwallace-microsoft / @RogerBarreto, could you please help?

@westey-m
Copy link
Contributor

westey-m commented Mar 31, 2025 •
edited
Loading

@shethaadit, thanks for the PR!
This change actually needs to target the feature branch: https://github.com/microsoft/semantic-kernel/tree/feature-vector-data-preb2
It might be easier to redo the change against the feature branch though, since there are a lot of changes in the feature branch.

Do you mind also renaming IsFullTextSearchable to IsFullTextIndexed?

FYI: We are batching up breaking changes in the feature branch to avoid causing lots of small changes for users, and instead release them together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kernel Issues or pull requests impacting the core kernel memory .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MEVD] Consider renaming IsFilterable to IsIndexed
3 participants
@shethaadit @westey-m @markwallace-microsoft