Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Introducing the SQL Connector #10981

Merged
merged 30 commits into from
Apr 3, 2025

Conversation

eavanvalkenburg
Copy link
Member

@eavanvalkenburg eavanvalkenburg commented Mar 14, 2025

Motivation and Context

This PR adds the Azure SQL Store and Collection
Closes #9882

Description

Contribution Checklist

@eavanvalkenburg eavanvalkenburg requested a review from a team as a code owner March 14, 2025 14:10
@eavanvalkenburg eavanvalkenburg marked this pull request as draft March 14, 2025 14:10
@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel memory labels Mar 14, 2025
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented Mar 14, 2025

Python Unit Test Overview

Tests Skipped Failures Errors Time
3372 5 💤 0 ❌ 0 🔥 1m 38s ⏱️

@eavanvalkenburg eavanvalkenburg force-pushed the sql branch 3 times, most recently from 504dae9 to 94368e6 Compare March 19, 2025 13:21
@eavanvalkenburg eavanvalkenburg marked this pull request as ready for review March 21, 2025 11:23
TaoChenOSU
TaoChenOSU previously approved these changes Mar 27, 2025
@eavanvalkenburg eavanvalkenburg changed the title Python: Introducing the Azure SQL Connector Python: Introducing the SQL Connector Mar 31, 2025
moonbox3
moonbox3 previously approved these changes Mar 31, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Mar 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 31, 2025
TaoChenOSU
TaoChenOSU previously approved these changes Apr 1, 2025
@eavanvalkenburg eavanvalkenburg added this pull request to the merge queue Apr 3, 2025
Merged via the queue into microsoft:main with commit b1f64ee Apr 3, 2025
28 checks passed
@eavanvalkenburg eavanvalkenburg deleted the sql branch April 3, 2025 10:54
glorious-beard pushed a commit to glorious-beard/semantic-kernel that referenced this pull request Apr 6, 2025
### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
This PR adds the Azure SQL Store and Collection
Closes microsoft#9882 


### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: Add (Azure) SQL Memory Connector with new Vector Search Design
5 participants