[localization-plugin] Add a feature for injecting custom localized values into a compilation #5262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
octogonz,
apostolisms,
D4N14L,
dmichon-msft and
TheLarkInn
as code owners
| private readonly _pseudolocalizers: Map<string, (str: string) => string> = new Map(); | ||
| private _customValueSuffixCounter: number = 0; |
There was a problem hiding this comment.
Using a counter makes the algorithm nondeterministic and therefore not play nicely with running in watch mode. That's why I swapped the string replacement engine to use hashes instead of an auto-incrementing id.
There was a problem hiding this comment.
I added a unique ID parameter, but I can't say I love that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a feature to the Webpack 5 localization plugin that allows users to inject custom localized values into a compilation.
How it was tested
Introduced unit tests.