-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Implement accessibilityLevel test in ScrollView Playground #14789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
const baseStyle = horizontal ? styles.baseHorizontal : styles.baseVertical; | ||
|
||
const {experimental_endDraggingSensitivityMultiplier, ...otherProps} = | ||
this.props; | ||
const props = { | ||
...otherProps, | ||
accessible, // [Windows] | ||
accessibilityLevel, // [Windows] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think this would change anything. accessibilityLevel would already be set by ...otherProps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok it was marked as "Not done" in RNW prop database for Fabric.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the accessiblityLevel show up in Accessibility Insights?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea it works.. the issue was it shows red line when scrollview is imported from "react-native" but works find for "react-native-windows".. updating playground here for testing purpose only. Added screenshots in description please check.
I think accessibilityLevel should show up in the E2E snapshots: react-native-windows/packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp Line 558 in 40f17ad
So you can probably add it to one of the E2E tests, and verify that it shows up in the snapshot. |
This reverts commit e137e1b.
Updated PR description and code to avoid confusion. |
This reverts commit d9b81a6.
Description
Type of Change
Why
Implement accessibilityLevel in ScrollView
What
Implement accessibilityLevel in ScrollView which was missing in JS codebase.
#14550
Screenshots
Before
importing scrollview from "react-native" shows error but importing from "react-native-windows" doesn't on js

After
Changelog
Should this change be included in the release notes: NO