Skip to content

Implement accessibilityLevel test in ScrollView Playground #14789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

anupriya13
Copy link
Contributor

@anupriya13 anupriya13 commented Jun 17, 2025

Description

Type of Change

  • Test case

Why

Implement accessibilityLevel in ScrollView

What

Implement accessibilityLevel in ScrollView which was missing in JS codebase.
#14550

Screenshots

Before

importing scrollview from "react-native" shows error but importing from "react-native-windows" doesn't on js
image

image

After

image

image

image

Changelog

Should this change be included in the release notes: NO

@anupriya13 anupriya13 marked this pull request as ready for review June 17, 2025 11:16
@anupriya13 anupriya13 requested a review from a team as a code owner June 17, 2025 11:16
const baseStyle = horizontal ? styles.baseHorizontal : styles.baseVertical;

const {experimental_endDraggingSensitivityMultiplier, ...otherProps} =
this.props;
const props = {
...otherProps,
accessible, // [Windows]
accessibilityLevel, // [Windows]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this would change anything. accessibilityLevel would already be set by ...otherProps.

Copy link
Contributor Author

@anupriya13 anupriya13 Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok it was marked as "Not done" in RNW prop database for Fabric.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the accessiblityLevel show up in Accessibility Insights?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea it works.. the issue was it shows red line when scrollview is imported from "react-native" but works find for "react-native-windows".. updating playground here for testing purpose only. Added screenshots in description please check.

@acoates-ms
Copy link
Contributor

I think accessibilityLevel should show up in the E2E snapshots:

So you can probably add it to one of the E2E tests, and verify that it shows up in the snapshot.

@anupriya13
Copy link
Contributor Author

I think accessibilityLevel should show up in the E2E snapshots:

So you can probably add it to one of the E2E tests, and verify that it shows up in the snapshot.

Updated PR description and code to avoid confusion.

@anupriya13 anupriya13 changed the title Implement accessibilityLevel in ScrollView Implement accessibilityLevel test in ScrollView Playground Jun 17, 2025
This reverts commit d9b81a6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants