Add UIBatchingQueue to bridgeless mode #12812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
approved these changes
Mar 8, 2024
…getting run when the instance load completed
…time before creating the ReactInstance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to this, there was no UIBatchingQueue being created when in bridgeless mode, which would cause the animation module to crash when used.
Updated snapshots to account for the layout conformance property which works correctly in bridgeless mode
Fixed an issue if you set a ReactViewHost on a CompositionRootView before the ReactHost was loaded
Fixed an issue in the Bridgeless timing module that was causing all timers to immediately fire
Moved some of the JS runtime initialization in bridgeless to be run on the JS thread synchronously to align with how we init it in bridge mode.
Fixed an issue where we wouldn't start the HMRClient in bridgeless mode
Fixed an issue where calls to JSFunctions hit during initialization may not get triggered when the runtime completed its initialization.
Resolves #12810