fix(windows): allow specifying MSBuild properties #2497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: Android
JasonVMo
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow specifying MSBuild properties, similar to
@react-native-windows/cli.The motivation for this feature is GitHub Actions' sudden removal of a Windows SDK version required by React Native Windows, without so much as a notice or warning anywhere. This currently causes all Windows builds to fail:
Command failed with error MSBuildError: C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.WindowsSDK.targets(46,5): error MSB8036: The Windows SDK version 10.0.22621.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". [D:\a\react-native-test-app\react-native-test-app\example\node_modules\.generated\windows\UWP\ReactTestApp.vcxproj](Example build log: https://github.com/microsoft/react-native-test-app/actions/runs/15815022444/job/44572279102)
Adding this feature will allow us to specify the Windows SDK version in our GitHub Actions workflows.
Platforms affected
Test plan
CI should pass.