Skip to content

ci(macos): re-enable smoke test #2468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ jobs:
with:
project-directory: macos
working-directory: example
- name: Build x86
- name: Build
if: ${{ steps.affected.outputs.macos != '' }}
run: |
../scripts/build/xcodebuild.sh macos/Example.xcworkspace build-for-testing
Expand All @@ -384,27 +384,10 @@ jobs:
node --test test/config.test.mjs
working-directory: example
- name: Test
# Temporarily disabled due to random failures
if: false # ${{ steps.affected.outputs.macos != '' && github.event_name != 'schedule' }}
if: ${{ steps.affected.outputs.macos != '' && github.event_name != 'schedule' }}
run: |
../scripts/build/xcodebuild.sh macos/Example.xcworkspace test-without-building
working-directory: example
- name: Prepare for arm64 build
if: ${{ steps.affected.outputs.macos != '' }}
run: |
rm -fr macos/build
working-directory: example
- name: Install Pods
if: ${{ steps.affected.outputs.macos != '' }}
uses: ./.github/actions/cocoapods
with:
project-directory: macos
working-directory: example
- name: Build arm64
if: ${{ steps.affected.outputs.macos != '' }}
run: |
../scripts/build/xcodebuild.sh macos/Example.xcworkspace build ARCHS=arm64
working-directory: example
timeout-minutes: 60
macos-template:
name: "macOS [template]"
Expand Down
2 changes: 2 additions & 0 deletions example/ios/ExampleTests/DevSupportTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ - (void)testDevSupportIsLinked
XCTAssertNotNil(ReactAppDidFinishLaunchingNotification);
XCTAssertNotNil(ReactAppWillInitializeReactNativeNotification);
XCTAssertNotNil(ReactAppDidInitializeReactNativeNotification);
XCTAssertNotNil(ReactAppRuntimeReadyNotification);
XCTAssertNotNil(ReactAppDidRegisterAppsNotification);
XCTAssertNotNil(ReactAppSceneDidOpenURLNotification);
}

Expand Down
Loading