Skip to content

[0.78.1] Release build failure #2449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jmeistrich opened this issue Mar 29, 2025 · 1 comment
Open

[0.78.1] Release build failure #2449

jmeistrich opened this issue Mar 29, 2025 · 1 comment
Labels
bug Something isn't working Needs: Triage 🔍

Comments

@jmeistrich
Copy link

Environment

react-native -v: 0.78.1
npm ls react-native-macos: 0.78.1
node -v: v20.14.0
npm -v: 10.9.2
yarn --version: n/a
xcodebuild -version: Xcode 16.1, Build version 16B40

Steps to reproduce the bug

  1. Initialize a fresh project with 0.78.1
  2. Runs fine in dev
  3. Errors in release

Expected Behavior

Build should succeed

Actual Behavior

Build failed with these warnings/errors

In file included from /Users/jay/Documents/code/test-projects/rnmac78/node_modules/react-native-macos/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm:12:
In file included from /Users/jay/Documents/code/test-projects/rnmac78/macos/Pods/Headers/Public/React-RCTFBReactNativeSpec/FBReactNativeSpec/FBReactNativeSpec.h:24:
/Users/jay/Documents/code/test-projects/rnmac78/macos/Pods/Headers/Public/RCTTypeSafety/RCTTypeSafety/RCTConvertHelpers.h:27:24: warning: use of GNU ?: conditional expression extension,
      omitting middle operand [-Wgnu-conditional-omitted-operand]
   27 |     array[i] = object ?: (id)kCFNull;
      |                        ^
/Users/jay/Documents/code/test-projects/rnmac78/node_modules/react-native-macos/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm:213:1: warning: implementing deprecated
      method [-Wdeprecated-implementations]
  213 | - (NSArray<id<RCTBridgeModule>> *)extraModulesForBridge:(RCTBridge *)bridge
      | ^
In file included from /Users/jay/Documents/code/test-projects/rnmac78/node_modules/react-native-macos/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm:36:
/Users/jay/Documents/code/test-projects/rnmac78/macos/Pods/Headers/Public/React-NativeModulesApple/ReactCommon/RCTTurboModuleManager.h:53:1: note: method 'extraModulesForBridge:' declared
      here
   53 | - (NSArray<id<RCTBridgeModule>> *)extraModulesForBridge:(RCTBridge *)bridge
      | ^
/Users/jay/Documents/code/test-projects/rnmac78/node_modules/react-native-macos/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm:216:29: warning: 'extraModulesForBridge:'
      is deprecated: Please make all native modules returned from this method TurboModule-compatible. [-Wdeprecated-declarations]
  216 |     return [_appTMMDelegate extraModulesForBridge:nil];
      |                             ^
In file included from /Users/jay/Documents/code/test-projects/rnmac78/node_modules/react-native-macos/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm:36:
/Users/jay/Documents/code/test-projects/rnmac78/macos/Pods/Headers/Public/React-NativeModulesApple/ReactCommon/RCTTurboModuleManager.h:54:18: note: 'extraModulesForBridge:' has been
      explicitly marked deprecated here
   54 |     __attribute((deprecated("Please make all native modules returned from this method TurboModule-compatible.")));
      |                  ^
/Users/jay/Documents/code/test-projects/rnmac78/node_modules/react-native-macos/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm:520:19: warning: 
      'instance:didReceiveJSErrorStack:message:originalMessage:name:componentStack:exceptionId:isFatal:extraData:' is deprecated [-Wdeprecated-declarations]
  520 |   if (![_delegate instance:self
      |                   ^
In file included from /Users/jay/Documents/code/test-projects/rnmac78/node_modules/react-native-macos/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm:8:
/Users/jay/Documents/code/test-projects/rnmac78/node_modules/react-native-macos/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.h:56:85: note: 
      'instance:didReceiveJSErrorStack:message:originalMessage:name:componentStack:exceptionId:isFatal:extraData:' has been explicitly marked deprecated here
   56 |                  extraData:(NSDictionary<NSString *, id> *)extraData __attribute__((deprecated));
      |                                                                                     ^
/Users/jay/Documents/code/test-projects/rnmac78/node_modules/react-native-macos/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm:527:34: error: cannot initialize a
      parameter of type 'BOOL' (aka 'signed char') with an rvalue of type 'id _Nullable'
  527 |                          isFatal:errorData[@"isFatal"]
      |                                  ^~~~~~~~~~~~~~~~~~~~~
In file included from /Users/jay/Documents/code/test-projects/rnmac78/node_modules/react-native-macos/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.mm:8:
/Users/jay/Documents/code/test-projects/rnmac78/node_modules/react-native-macos/ReactCommon/react/runtime/platform/ios/ReactCommon/RCTInstance.h:55:34: note: passing argument to parameter
      'isFatal' here
   55 |                    isFatal:(BOOL)isFatal
      |                                  ^
4 warnings and 1 error generated.

Reproducible Demo

No response

Additional context

No response
@jmeistrich jmeistrich added the bug Something isn't working label Mar 29, 2025
bear-ei added a commit to bear-ei/react-native-macos that referenced this issue Apr 11, 2025
@bear-ei
fix[0.78.1]: Fix the compilation failure caused by errorData[@"isFata…
6949456 
…l"] returning an NSNumber. (microsoft#2449)
@bear-ei bear-ei mentioned this issue Apr 11, 2025
Merged
bear-ei added a commit to bear-ei/react-native-macos that referenced this issue Apr 12, 2025
@bear-ei
fix(0.78.1): Fix the issue of TextInput onBlur being ineffective and …
261c2ba 
…the compilation failure. ( microsoft#2319)(microsoft#2449)
@bear-ei bear-ei mentioned this issue Apr 12, 2025
Merged
bear-ei added a commit to bear-ei/react-native-macos that referenced this issue Apr 12, 2025
@bear-ei
fix(0.78.1): Fix the issue of TextInput onBlur being ineffective and…
a1f79a3 
… the compilation failure. ( microsoft#2319)(microsoft#2449)
bear-ei added a commit to bear-ei/react-native-macos that referenced this issue Apr 12, 2025
@bear-ei
fix(0.78.1): Fix the issue of TextInput onBlur being ineffective and …
47b9f21 
…the compilation failure. ( microsoft#2319)(microsoft#2449)
Saadnajmi pushed a commit that referenced this issue Apr 15, 2025
@bear-ei
fix: Fix the issue of TextInput onBlur being ineffective and Release …
fd4d1fa 
…build failure (#2469)

> ## Summary:
> Fix Release build failure #2449
> Fix TextInput onBlur is invalid #2319
> ## Test Plan:
> Run react-native-macos-init and check that the created project builds
and run.
Saadnajmi pushed a commit that referenced this issue Apr 15, 2025
@bear-ei
fix(0.78): Fix the compilation failure caused by errorData[@"isFata… (#…
ccfa0f7 
…2468)

> ## Summary:
> Fix Release build failure #2449
> Fix TextInput onBlur is invalid #2319
> ## Test Plan:
> Run react-native-macos-init and check that the created project builds
and run.
@rajupushpad
Copy link

@Saadnajmi @jmeistrich ,
Getting error while creating release build.
version - ^0.78.2
Error - 'instance:didReceiveJSErrorStack:message:originalMessage:name:componentStack:exceptionId:isFatal:extraData:' is deprecated

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Needs: Triage 🔍
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmeistrich @rajupushpad