Skip to content

added support for SecurityGroupId #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions nuget.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,6 @@
"name": "nuget.org",
"url": "https://api.nuget.org/v3-flatcontainer/",
"authenticated": false,
"packages": [
]
},
{
"name": "CAP_ISVExp_Tools_Stable",
"url": "https://pkgs.dev.azure.com/msazure/_packaging/b0441cf8-0bc8-4fad-b126-841a6184e784/nuget/v3/flat2/",
"authenticated": true,
"patEnvironmentVariable": "AZ_DevOps_Read_PAT",
"packages": [
{
"name": "Microsoft.PowerApps.CLI",
Expand All @@ -26,13 +18,19 @@
}
]
},
{
"name": "CAP_ISVExp_Tools_Stable",
"url": "https://pkgs.dev.azure.com/msazure/_packaging/b0441cf8-0bc8-4fad-b126-841a6184e784/nuget/v3/flat2/",
"authenticated": true,
"patEnvironmentVariable": "AZ_DevOps_Read_PAT",
"packages": []
},
{
"name": "CAP_ISVExp_Tools_Daily",
"url": "https://pkgs.dev.azure.com/msazure/_packaging/d3fb5788-d047-47f9-9aba-76890f5cecf0/nuget/v3/flat2/",
"authenticated": true,
"patEnvironmentVariable": "AZ_DevOps_Read_PAT",
"packages": [
]
"packages": []
}
]
}
15 changes: 7 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"yargs": "^17.7.2"
},
"dependencies": {
"@microsoft/powerplatform-cli-wrapper": "^0.1.118",
"@microsoft/powerplatform-cli-wrapper": "^0.1.120",
"azure-pipelines-task-lib": "^4.9.1",
"debug": "^4.3.4",
"fs-extra": "^11.1.1",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ export async function main(): Promise<void> {
templates: parameterMap['AppsTemplate'],
domainName: parameterMap['DomainName'],
teamId: parameterMap['TeamId'],
securityGroupId: parameterMap['SecurityGroupId'],
logToConsole: isDiagnosticsMode ? true : false
}, new BuildToolsRunnerParams(), new BuildToolsHost());

Expand Down
7 changes: 7 additions & 0 deletions src/tasks/create-environment/create-environment-v2/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,13 @@
"type": "string",
"required": false,
"helpMarkDown": "The ID of the Microsoft Teams team to create the Power Apps environment in."
},
{
"name": "SecurityGroupId",
"label": "Security Group ID",
"type": "string",
"required": false,
"helpMarkDown": "Microsoft Entra ID Security Group ID to use when creating the environment."
}
],
"execution": {
Expand Down
1 change: 1 addition & 0 deletions test/unit-test/create-environment.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ describe("create-environment tests", () => {
templates: { name: 'AppsTemplate', required: false, defaultValue: undefined },
domainName: { name: 'DomainName', required: true, defaultValue: undefined },
teamId: { name: 'TeamId', required: false, defaultValue: undefined },
securityGroupId: { name: 'SecurityGroupId', required: false, defaultValue: undefined },
logToConsole: false
}, new BuildToolsRunnerParams(), new BuildToolsHost());
});
Expand Down
Loading