Skip to content

Load AMS based on config definition #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Apr 7, 2025

Conversation

elopezanaya
Copy link
Contributor

@elopezanaya elopezanaya commented Mar 31, 2025

PR Details

Thank you for your contribution. Before submitting this PR, please include:

Id of the task, bug, story or other reference

Description

Include a description of the problem to be solved

  • Detected a double load of AMS when debug is declared.
  • Detected scenario where startChat is finishing before AMS is loaded, causing disruption when trying to load files , or during reload , files already attached may not be present.
     

Solution Proposed

Detail what is the solution proposed, include links to design document if required or any other document required to support the solution

  • Patch to prevent double load
  • Patch to prevent start chat to finish before AMS is loaded
  • Load AMS only when config is enabled for agent or customer, otherwise do not load it.

SDK needs to ensure AMS is loaded before session starts, the delay in the load needs to be investigated in AMS client

Acceptance criteria

Define what are the conditions to consider the PR has achieved the intended goal

Test cases and evidence

Load AMS in the background : delay 13 seconds for AMS creation

image

Reload, delay to wait for AMS complete, 12 seconds

image

image

Load Widget, AMS not supported , 1,3 seconds to load

image

Include what tests cases were considered, any evidence of testing for future references, to identify any corner cases, etc

Sanity Tests

  • You have tested all changes in Popout mode
  • You have tested all changes in cross browsers i.e Edge, Chrome, Firefox, Safari and mobile devices(iOS and Android)
  • Your changes are included in the CHANGELOG

A11y

Please provide justification if any of the validations has been skipped.

@elopezanaya elopezanaya requested a review from xTEddie April 1, 2025 19:43
@elopezanaya elopezanaya requested a review from xTEddie April 2, 2025 20:58
mithunjohny
mithunjohny previously approved these changes Apr 4, 2025
mithunjohny
mithunjohny previously approved these changes Apr 4, 2025
@elopezanaya elopezanaya requested a review from xTEddie April 4, 2025 22:28
xTEddie
xTEddie previously approved these changes Apr 7, 2025
@elopezanaya elopezanaya merged commit 243dcc1 into microsoft:main Apr 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants