-
Notifications
You must be signed in to change notification settings - Fork 43
Load AMS based on config definition #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+409
−211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xTEddie
reviewed
Apr 1, 2025
xTEddie
reviewed
Apr 1, 2025
xTEddie
reviewed
Apr 1, 2025
xTEddie
reviewed
Apr 1, 2025
xTEddie
reviewed
Apr 1, 2025
xTEddie
reviewed
Apr 1, 2025
xTEddie
reviewed
Apr 1, 2025
xTEddie
reviewed
Apr 1, 2025
xTEddie
reviewed
Apr 3, 2025
xTEddie
reviewed
Apr 3, 2025
mithunjohny
previously approved these changes
Apr 4, 2025
xTEddie
reviewed
Apr 4, 2025
xTEddie
reviewed
Apr 4, 2025
xTEddie
reviewed
Apr 4, 2025
xTEddie
reviewed
Apr 4, 2025
xTEddie
reviewed
Apr 4, 2025
mithunjohny
previously approved these changes
Apr 4, 2025
xTEddie
reviewed
Apr 7, 2025
xTEddie
reviewed
Apr 7, 2025
xTEddie
reviewed
Apr 7, 2025
xTEddie
reviewed
Apr 7, 2025
xTEddie
reviewed
Apr 7, 2025
xTEddie
previously approved these changes
Apr 7, 2025
xTEddie
approved these changes
Apr 7, 2025
mithunjohny
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
Thank you for your contribution. Before submitting this PR, please include:
Id of the task, bug, story or other reference
Description
Include a description of the problem to be solved
Solution Proposed
Detail what is the solution proposed, include links to design document if required or any other document required to support the solution
SDK needs to ensure AMS is loaded before session starts, the delay in the load needs to be investigated in AMS client
Acceptance criteria
Define what are the conditions to consider the PR has achieved the intended goal
Test cases and evidence
Load AMS in the background : delay 13 seconds for AMS creation
Reload, delay to wait for AMS complete, 12 seconds
Load Widget, AMS not supported , 1,3 seconds to load
Include what tests cases were considered, any evidence of testing for future references, to identify any corner cases, etc
Sanity Tests
A11y
Please provide justification if any of the validations has been skipped.