Skip to content

Published npm node module contains *.test.js #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aeschli opened this issue Feb 18, 2022 · 1 comment · Fixed by #530
Closed

Published npm node module contains *.test.js #528

aeschli opened this issue Feb 18, 2022 · 1 comment · Fixed by #530
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@aeschli
Copy link

aeschli commented Feb 18, 2022

The node-pty node module contains several .test.js files.

node-pty is part of the vscode build and I'm looking into reducing the number of files we ship wth.

|   +---node-pty
|   |   |   LICENSE
|   |   |   package.json
|   |   |   
|   |   +---build
|   |   |   \---Release
|   |   |           conpty.node
|   |   |           conpty_console_list.node
|   |   |           pty.node
|   |   |           winpty-agent.exe
|   |   |           winpty.dll
|   |   |           
|   |   \---lib
|   |       |   conpty_console_list_agent.js
|   |       |   eventEmitter2.js
|   |       |   eventEmitter2.test.js
|   |       |   index.js
|   |       |   interfaces.js
|   |       |   terminal.js
|   |       |   terminal.test.js
|   |       |   testUtils.test.js
|   |       |   types.js
|   |       |   unixTerminal.js
|   |       |   unixTerminal.test.js
|   |       |   utils.js
|   |       |   windowsConoutConnection.js
|   |       |   windowsPtyAgent.js
|   |       |   windowsPtyAgent.test.js
|   |       |   windowsTerminal.js
|   |       |   windowsTerminal.test.js
|   |       |   
|   |       +---shared
|   |       |       conout.js
|   |       |       
|   |       \---worker
|   |               conoutSocketWorker.js
@Tyriar Tyriar added this to the 1.0.0 milestone Feb 22, 2022
@Tyriar Tyriar self-assigned this Feb 22, 2022
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Feb 22, 2022
Tyriar added a commit that referenced this issue Feb 22, 2022
@Tyriar
Copy link
Member

Tyriar commented Feb 22, 2022

Ignored in #530, it might be some time until we update node-pty though as there were problems integrating the latest version.

xiaobaidadada pushed a commit to xiaobaidadada/node-pty-prebuilt that referenced this issue Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants