-
Notifications
You must be signed in to change notification settings - Fork 577
Support babeltrace2 with fallback to babeltrace #5141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: nibanks <[email protected]>
Our Build workflows are failing on Linux runs with the following:
|
…lation Co-authored-by: nibanks <[email protected]>
... Fixed the PowerShell syntax error in prepare-machine.ps1. The issue was using bash-style Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5141 +/- ##
==========================================
- Coverage 87.38% 86.86% -0.53%
==========================================
Files 59 59
Lines 18037 18037
==========================================
- Hits 15761 15667 -94
- Misses 2276 2370 +94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There is commented script in scripts/run_endpoints.sh that refers to babeltrace cmds. Should this be updated or ignored or removed? Rest looks good to me. |
This PR adds support for
babeltrace2
while maintaining backward compatibility withbabeltrace
. Recent changes in lab environments have madebabeltrace2
the default installation whilebabeltrace
is no longer available by default.Changes Made
Scripts Updated
scripts/log_wrapper.sh
: Added detection logic to trybabeltrace2
first, then fallback tobabeltrace
scripts/log.ps1
:Get-BabeltraceCommand
helper function for version detectionscripts/prepare-machine.ps1
: Modified installation to trybabeltrace2
first with fallback tobabeltrace
Documentation
docs/Diagnostics.md
: Updated to mention both tools and provide usage examples for eachImplementation Details
The solution detects which babeltrace version is available and uses the appropriate command syntax:
For PowerShell scripts, the implementation uses a helper function:
Backward Compatibility
All changes maintain full backward compatibility. Systems with only
babeltrace
installed will continue to work unchanged, while systems withbabeltrace2
will automatically use the newer version.Fixes #5048.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
esm.ubuntu.com
/usr/lib/apt/methods/https
(dns block)http://168.63.129.16:80/machine/
/usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs
(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.