Skip to content

Remove DataIndication Queuing from Kernel Datapath #5091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2025

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented May 10, 2025

Description

For several years now, the Windows kernel datapath has been always copying the recevied data in to local buffers because we found that any significant queuing can cause problems lower in the stack (i.e., the NIC); even if we queued only 1 indication. So, let's just remove all the code that supported the queuing mode to eliminate unnecessary branches in the kernel datapath code.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner May 10, 2025 14:52
Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (f7890e3) to head (a86bbf5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5091      +/-   ##
==========================================
- Coverage   87.00%   86.74%   -0.27%     
==========================================
  Files          59       59              
  Lines       18035    18035              
==========================================
- Hits        15692    15645      -47     
- Misses       2343     2390      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nibanks nibanks enabled auto-merge (squash) May 12, 2025 12:40
@nibanks nibanks merged commit 3ab4e55 into main May 12, 2025
283 of 285 checks passed
@nibanks nibanks deleted the kernel-data-always-copy branch May 12, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants