Double free bugfix in Secnetperf #5081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5081 +/- ##
==========================================
- Coverage 87.26% 86.01% -1.26%
==========================================
Files 59 59
Lines 17995 17995
==========================================
- Hits 15704 15479 -225
- Misses 2291 2516 +225 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nibanks
approved these changes
May 6, 2025
|
Good catch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Recent netperf runs has been consistently bugchecking in WSK scenarios and failing with exit code 1 on linux runs.
This likely stemmed from recent refactors in the TCP codepaths (https://github.com/microsoft/msquic/pull/5015/files#diff-a3cdfe61c9e7048c98568a0977fd801e3a1b3f065e82a84b57bbf9146c17dac4)
Testing
CI
Documentation
N/A