Skip to content

Upload rust binding diff as an artifact #5077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 5, 2025
Merged
Show file tree
Hide file tree
Changes from 8 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/cargo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,24 @@ jobs:
id: bindings_diff
shell: bash
run: |
if git diff --exit-code >> cargo_generated_diff.txt; then
if git diff --exit-code >> cargo_binding_update.patch; then
echo "diff-found=false" >> $GITHUB_OUTPUT
else
echo "diff-found=true" >> $GITHUB_OUTPUT
{
echo 'diff-content<<@@@'
echo "$(cat cargo_generated_diff.txt)"
echo "$(cat cargo_binding_update.patch)"
echo '@@@'
} >> $GITHUB_OUTPUT
echo "$(cat cargo_binding_update.patch)"
fi
- name: Upload the patch file
if: steps.bindings_diff.outputs.diff-found == 'true'
id: upload_patch
uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02
with:
name: cargo_binding_update_${{ matrix.os }}
path: cargo_binding_update.patch
- name: Post a comment on PR on mismatch
if: |
!github.event.pull_request.head.repo.fork &&
Expand All @@ -72,8 +80,8 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}
issue-number: ${{ github.event.number }}
body: |
## ${{ github.workflow }}
The rust bindings need to be updated. Please apply (`git apply`) this diff:
## ${{ github.workflow }} - ${{ matrix.os }}
The rust bindings need to be updated. Please apply (`git apply`) this [patch](${{ steps.upload_patch.outputs.artifact-url }}):
```diff
${{ steps.bindings_diff.outputs.diff-content }}
```
Expand Down
3 changes: 3 additions & 0 deletions src/inc/msquic.h
Original file line number Diff line number Diff line change
Expand Up @@ -1746,6 +1746,9 @@ typedef struct QUIC_API_TABLE {
QUIC_CONNECTION_OPEN_IN_PARTITION_FN
ConnectionOpenInPartition; // Available from v2.5

QUIC_CONNECTION_OPEN_IN_PARTITION_FN
Dummy; // TODO guhetier: For testing CI, to remove

#ifdef QUIC_API_ENABLE_PREVIEW_FEATURES
QUIC_STREAM_PROVIDE_RECEIVE_BUFFERS_FN
StreamProvideReceiveBuffers; // Available from v2.5
Expand Down
Loading