Added RttVariance to connection statistics. #5070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added RttVariance to connection statistics.
nibanks
reviewed
May 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5070 +/- ##
==========================================
- Coverage 87.11% 86.89% -0.23%
==========================================
Files 59 59
Lines 17924 17926 +2
==========================================
- Hits 15615 15577 -38
- Misses 2309 2349 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nibanks
previously approved these changes
May 3, 2025
|
The Rust bindings need to be updated as well. |
Updated Rust bindings Made it clearer what the version number on the QUIC_STATISTICS_V2 sizes refers to.
jarnovanderlinden
force-pushed
the
rttvariance-statistic
branch
from
c4d14a0 to
68dd876
Compare
nibanks
approved these changes
May 6, 2025
|
Thanks so much for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added RttVariance to connection statistics. Fixes #4360
Description
Adds the RttVariance statistic to QUIC_STATISTICS_V2, allowing applications to monitor changes to the Rtt of a connection over time.