Skip to content

Increase Retry Limit for Key/CID Update Tests #5067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented May 2, 2025

Description

Increases the total wait time from 2 seconds to 5 seconds for the Key and CID update tests. We still occassionally see failures in these tests on oversubscribed VMs used for testing.

Closes #4325.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner May 2, 2025 12:26
@nibanks nibanks added Area: Testing Related to test coverage Area: Automation labels May 2, 2025
@nibanks nibanks enabled auto-merge (squash) May 2, 2025 12:32
@nibanks nibanks merged commit ff2c13d into main May 2, 2025
263 of 283 checks passed
@nibanks nibanks deleted the longer-retries branch May 2, 2025 12:51
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (64c7089) to head (f1d0b12).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5067      +/-   ##
==========================================
- Coverage   87.33%   85.39%   -1.95%     
==========================================
  Files          59       59              
  Lines       17927    17927              
==========================================
- Hits        15657    15309     -348     
- Misses       2270     2618     +348     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Automation Area: Testing Related to test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misc/WithKeyUpdateArgs1.KeyUpdate/7 failure
2 participants