Skip to content

Avoid passing incompatible argument to ninja in build.ps1 #5038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025

Conversation

mtfriesen
Copy link
Contributor

Description

Describe the purpose of and changes within this Pull Request.

The VERBOSE=1 arg is nonstandard and not supported by Ninja build, so pass that param only to default or "cmake" generators.

Testing

Do any existing tests cover this change? Are new tests needed?

Seems to work on my machine.

Documentation

Is there any documentation impact for this change?

Nope.

@mtfriesen mtfriesen requested a review from a team as a code owner April 22, 2025 17:33
@mtfriesen mtfriesen enabled auto-merge (squash) April 22, 2025 17:37
@mtfriesen mtfriesen merged commit 79983ad into main Apr 22, 2025
422 of 424 checks passed
@mtfriesen mtfriesen deleted the mtfriesen/ninja_build branch April 22, 2025 18:13
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.06%. Comparing base (5caaedc) to head (2a196b4).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5038      +/-   ##
==========================================
- Coverage   87.26%   87.06%   -0.20%     
==========================================
  Files          59       59              
  Lines       18011    18011              
==========================================
- Hits        15717    15681      -36     
- Misses       2294     2330      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants