Skip to content

Print connections and stream number for more useful throughput data #5037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2025

Conversation

imorlxs
Copy link
Contributor

@imorlxs imorlxs commented Apr 22, 2025

Description

In #5023, PrintThroughput was changed and PrintConnThroughput was added. This add the number of connections and streams to the -ptput argument, which prints the sum of the throughputs.

Testing

Do any existing tests cover this change? Are new tests needed?

Documentation

The documentation has to be updated. The -pctput argument is not documented.

@imorlxs imorlxs requested a review from a team as a code owner April 22, 2025 11:47
@nibanks nibanks added Area: Testing Related to test coverage external Proposed by non-MSFT labels Apr 22, 2025
@nibanks nibanks enabled auto-merge (squash) April 22, 2025 12:00
@nibanks nibanks merged commit 930f65e into microsoft:main Apr 22, 2025
422 of 423 checks passed
Copy link

codecov bot commented Apr 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.06%. Comparing base (186accc) to head (d602bb5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5037      +/-   ##
==========================================
- Coverage   86.28%   86.06%   -0.23%     
==========================================
  Files          59       59              
  Lines       18011    18011              
==========================================
- Hits        15541    15501      -40     
- Misses       2470     2510      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Related to test coverage external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants