Shutdown Connections on QuicTestHandshakeSpecificLossPatterns Exit #5025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5025 +/- ##
==========================================
- Coverage 87.36% 86.98% -0.39%
==========================================
Files 59 59
Lines 18011 18011
==========================================
- Hits 15736 15666 -70
- Misses 2275 2345 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mtfriesen
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
QuicTestHandshakeSpecificLossPatternsto have the registration shutdown/abort any leftover connections on test exit.Related to #5024, but may not fix it.
Testing
CI/CD
Documentation
N/A