Skip to content

External Execution Interface #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
May 7, 2025
Merged
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
448184f
Initial External Execution Interface
nibanks Oct 16, 2024
442c928
Make .NET and Kernel mode happy
nibanks Oct 16, 2024
e0f9d13
Check function
nibanks Oct 16, 2024
adb9ad9
Incomplete example
nibanks Oct 16, 2024
882e630
Simplify
nibanks Oct 16, 2024
da9e0b2
Fix .net
nibanks Oct 16, 2024
94efc44
Remove leftovers
nibanks Oct 16, 2024
9695592
fixes
nibanks Oct 16, 2024
4554407
wip
nibanks Oct 18, 2024
40d1e84
wip
nibanks Oct 28, 2024
74835cf
docs
nibanks Oct 31, 2024
f73a471
Merge branch 'main' into external-execution
nibanks Dec 5, 2024
b743020
A bit of documentation
nibanks Dec 6, 2024
dd7abe0
c++ formatting is nicer
nibanks Dec 6, 2024
be0855e
Merge branch 'main' into external-execution
nibanks Jan 4, 2025
919ae67
Updates to latest design
nibanks Jan 4, 2025
0e4b73d
Merge branch 'main' into external-execution
nibanks Jan 7, 2025
94b4c3f
wip
nibanks Jan 8, 2025
446a9f3
wip
nibanks Jan 22, 2025
f39e7f8
Merge branch 'main' into external-execution
nibanks Mar 17, 2025
b15ba57
Merge branch 'main' into external-execution
nibanks Mar 18, 2025
4a86d10
Merge branch 'main' into external-execution
nibanks Apr 10, 2025
bd22e7d
Merge branch 'main' into external-execution
nibanks Apr 17, 2025
c5b97f8
WIP
nibanks Apr 17, 2025
d2d209c
Merge branch 'main' into external-execution
nibanks Apr 28, 2025
3264294
Merge branch 'main' into external-execution
nibanks Apr 28, 2025
9603086
wip
nibanks Apr 28, 2025
a06aa81
renames
nibanks Apr 28, 2025
8c7c05b
Fix clog
nibanks Apr 28, 2025
8948a57
Merge branch 'main' into external-execution
nibanks Apr 30, 2025
2e1bf82
Merge branch 'main' into external-execution
nibanks May 6, 2025
74b8cb9
Fix clean up code
nibanks May 6, 2025
9ccc97d
fix builds
nibanks May 6, 2025
4cab2f5
fixes
nibanks May 6, 2025
7c4b651
Merge branch 'main' into external-execution
nibanks May 6, 2025
ad32894
Single thread test app works!
nibanks May 6, 2025
2039771
unreferenced parameters
nibanks May 6, 2025
a44b999
Fix kernel builds
nibanks May 6, 2025
da26362
another try for kernel mode
nibanks May 6, 2025
e5731f4
Trying to fix rust
nibanks May 6, 2025
38feb45
another try
nibanks May 6, 2025
fd4a623
Another try
nibanks May 6, 2025
630aa78
Another try
nibanks May 6, 2025
f387952
forgot one
nibanks May 6, 2025
cfefdf8
oops
nibanks May 6, 2025
2924b64
hack for mac
nibanks May 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 72 additions & 0 deletions docs/Execution.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,3 +109,75 @@ graph TD
end
end
```

## Custom Execution

MsQuic also supports scenarios where the application layer creates the threads that MsQuic uses to execute on.
In this mode, the application creates one or more execution contexts that MsQuic will use to run all its internal logic.
The application is responsible for calling down into MsQuic to allow these execution contexts to run.

To create an execution context, the app much first create an event queue object, which is a platform specific type:

- Windows: IOCP
- Linux: epoll
- macOS: kqueue

On Windows, the following types are defined:

```c++
typedef HANDLE QUIC_EVENTQ;

typedef OVERLAPPED_ENTRY CXPLAT_CQE;

typedef
_IRQL_requires_max_(PASSIVE_LEVEL)
void
(CXPLAT_EVENT_COMPLETION)(
_In_ CXPLAT_CQE* Cqe
);
typedef CXPLAT_EVENT_COMPLETION *CXPLAT_EVENT_COMPLETION_HANDLER;

typedef struct CXPLAT_SQE {
OVERLAPPED Overlapped;
CXPLAT_EVENT_COMPLETION_HANDLER Completion;
} CXPLAT_SQE;
```

You will also notice the definiton for `QUIC_SQE` (SQE stands for submission queue entry), which defines the format that all completion events must take so they may be generically processed from the event queue (more on this below).

Once the app has the event queue, it may create the execution context with the `ExecutionCreate` function:

```c++
HANDLE IOCP = CreateIoCompletionPort(INVALID_HANDLE_VALUE, nullptr, 0, 1);
QUIC_EXECUTION_CONTEXT_CONFIG ExecConfig = { 0, &IOCP };

QUIC_EXECUTION_CONTEXT* ExecContext = nullptr;
QUIC_STATUS Status = MsQuic->ExecutionCreate(QUIC_EXECUTION_CONFIG_FLAG_NONE, 0, 1, &ExecConfig, &ExecContext);
```

The above code createa a new IOCP (for Windows), sets up an execution config, indicating an ideal processor of 0 and the pointer to the IOCP, and then calls MsQuic to create 1 execution context.
An application may expand this code to create multiple execution contexts, depending on their needs.

To drive this execution context, the app will need to to periodically call `ExecutionPoll` and use the platform specific function to drain completion events from the event queue.

```c
bool AllDone = false;
while (!AllDone) {
uint32_t WaitTime = MsQuic->ExecutionPoll(ExecContext);

ULONG OverlappedCount = 0;
OVERLAPPED_ENTRY Overlapped[8];
if (GetQueuedCompletionStatusEx(IOCP, Overlapped, ARRAYSIZE(Overlapped), &OverlappedCount, WaitTime, FALSE)) {
for (ULONG i = 0; i < OverlappedCount; ++i) {
QUIC_SQE* Sqe = CONTAINING_RECORD(Overlapped[i].lpOverlapped, QUIC_SQE, Overlapped);
Sqe->Completion(&Overlapped[i]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can user quic callback event be invoked on this user thread here?
(I am thinking about if it is possible to write a single thread application, and potential deadlocks.)

Copy link
Member Author

@nibanks nibanks May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the app I added in this PR is single threaded. It works and I have the logs to prove it.

}
}
}
```

Above, you can see a simple loop that properly drives a single execution context on Windows.
`OVERLAPPED_ENTRY` objects received from `GetQueuedCompletionStatusEx` are used to get the submission queue entry and then call its completion handler.

In a real application, these completion events may come both from MsQuic and the application itself, therefore, this means **the application must use the same base format for its own submission entries**.
This is necessary to be able to share the same event queue object.
25 changes: 25 additions & 0 deletions src/cs/lib/msquic_generated.cs
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,22 @@ internal unsafe partial struct QUIC_EXECUTION_CONFIG
internal fixed ushort ProcessorList[1];
}

internal unsafe partial struct QUIC_EXECUTION_CONTEXT_CONFIG
{
[NativeTypeName("uint32_t")]
internal uint IdealProcessor;

[NativeTypeName("uint32_t")]
internal uint PollingIdleTimeoutUs;

[NativeTypeName("QUIC_EVENTQ *")]
internal void** EventQ;
}

internal partial struct QUIC_EXECUTION_CONTEXT
{
}

internal unsafe partial struct QUIC_REGISTRATION_CONFIG
{
[NativeTypeName("const char *")]
Expand Down Expand Up @@ -3255,6 +3271,15 @@ internal unsafe partial struct QUIC_API_TABLE

[NativeTypeName("QUIC_CONNECTION_COMP_CERT_FN")]
internal delegate* unmanaged[Cdecl]<QUIC_HANDLE*, byte, QUIC_TLS_ALERT_CODES, int> ConnectionCertificateValidationComplete;

[NativeTypeName("QUIC_EXECUTION_CREATE_FN")]
internal delegate* unmanaged[Cdecl]<QUIC_EXECUTION_CONFIG_FLAGS, uint, QUIC_EXECUTION_CONTEXT_CONFIG*, QUIC_EXECUTION_CONTEXT**, int> ExecutionCreate;

[NativeTypeName("QUIC_EXECUTION_DELETE_FN")]
internal delegate* unmanaged[Cdecl]<uint, QUIC_EXECUTION_CONTEXT**, void> ExecutionDelete;

[NativeTypeName("QUIC_EXECUTION_POLL_FN")]
internal delegate* unmanaged[Cdecl]<QUIC_EXECUTION_CONTEXT*, uint> ExecutionPoll;
}

internal static unsafe partial class MsQuic
Expand Down
69 changes: 67 additions & 2 deletions src/inc/msquic.h
Original file line number Diff line number Diff line change
Expand Up @@ -265,16 +265,16 @@ typedef enum QUIC_DATAGRAM_SEND_STATE {
#define QUIC_DATAGRAM_SEND_STATE_IS_FINAL(State) \
((State) >= QUIC_DATAGRAM_SEND_LOST_DISCARDED)

#ifdef QUIC_API_ENABLE_PREVIEW_FEATURES

typedef enum QUIC_EXECUTION_CONFIG_FLAGS {
QUIC_EXECUTION_CONFIG_FLAG_NONE = 0x0000,
#ifdef QUIC_API_ENABLE_PREVIEW_FEATURES
QUIC_EXECUTION_CONFIG_FLAG_QTIP = 0x0001,
QUIC_EXECUTION_CONFIG_FLAG_RIO = 0x0002,
QUIC_EXECUTION_CONFIG_FLAG_XDP = 0x0004,
QUIC_EXECUTION_CONFIG_FLAG_NO_IDEAL_PROC = 0x0008,
QUIC_EXECUTION_CONFIG_FLAG_HIGH_PRIORITY = 0x0010,
QUIC_EXECUTION_CONFIG_FLAG_AFFINITIZE = 0x0020,
#endif
} QUIC_EXECUTION_CONFIG_FLAGS;

DEFINE_ENUM_FLAG_OPERATORS(QUIC_EXECUTION_CONFIG_FLAGS)
Expand All @@ -295,6 +295,62 @@ typedef struct QUIC_EXECUTION_CONFIG {
#define QUIC_EXECUTION_CONFIG_MIN_SIZE \
(uint32_t)FIELD_OFFSET(QUIC_EXECUTION_CONFIG, ProcessorList)

#ifndef _KERNEL_MODE

//
// Execution Context abstraction, which allows the application layer to
// completely control execution of all MsQuic work.
//

typedef struct QUIC_EXECUTION_CONTEXT_CONFIG {
uint32_t IdealProcessor;
QUIC_EVENTQ* EventQ;
} QUIC_EXECUTION_CONTEXT_CONFIG;

typedef struct QUIC_EXECUTION_CONTEXT QUIC_EXECUTION_CONTEXT;

//
// This is called to create the execution contexts.
//
typedef
_IRQL_requires_max_(PASSIVE_LEVEL)
QUIC_STATUS
(QUIC_API * QUIC_EXECUTION_CREATE_FN)(
_In_ QUIC_EXECUTION_CONFIG_FLAGS Flags, // Used for datapath type
_In_ uint32_t PollingIdleTimeoutUs,
_In_ uint32_t Count,
_In_reads_(Count) QUIC_EXECUTION_CONTEXT_CONFIG* Configs,
_Out_writes_(Count) QUIC_EXECUTION_CONTEXT** ExecutionContexts
);

//
// This is called to delete the execution contexts.
//
typedef
_IRQL_requires_max_(PASSIVE_LEVEL)
void
(QUIC_API * QUIC_EXECUTION_DELETE_FN)(
_In_ uint32_t Count,
_In_reads_(Count) QUIC_EXECUTION_CONTEXT** ExecutionContexts
);

//
// This is called to allow MsQuic to process any polling work. It returns the
// number of milliseconds until the next scheduled timer expiration.
//
// TODO: Should it return an indication for if we should yield?
//
typedef
_IRQL_requires_max_(PASSIVE_LEVEL)
uint32_t
(QUIC_API * QUIC_EXECUTION_POLL_FN)(
_In_ QUIC_EXECUTION_CONTEXT* ExecutionContext
);

#endif // _KERNEL_MODE

#endif // QUIC_API_ENABLE_PREVIEW_FEATURES

typedef struct QUIC_REGISTRATION_CONFIG { // All fields may be NULL/zero.
const char* AppName;
QUIC_EXECUTION_PROFILE ExecutionProfile;
Expand Down Expand Up @@ -861,6 +917,7 @@ void
#endif
#define QUIC_PARAM_GLOBAL_TLS_PROVIDER 0x0100000A // QUIC_TLS_PROVIDER
#define QUIC_PARAM_GLOBAL_STATELESS_RESET_KEY 0x0100000B // uint8_t[] - Array size is QUIC_STATELESS_RESET_KEY_LENGTH

//
// Parameters for Registration.
//
Expand Down Expand Up @@ -1630,6 +1687,14 @@ typedef struct QUIC_API_TABLE {
QUIC_CONNECTION_COMP_RESUMPTION_FN ConnectionResumptionTicketValidationComplete; // Available from v2.2
QUIC_CONNECTION_COMP_CERT_FN ConnectionCertificateValidationComplete; // Available from v2.2

#ifdef QUIC_API_ENABLE_PREVIEW_FEATURES
#ifndef _KERNEL_MODE
QUIC_EXECUTION_CREATE_FN ExecutionCreate; // Available from v2.5
QUIC_EXECUTION_DELETE_FN ExecutionDelete; // Available from v2.5
QUIC_EXECUTION_POLL_FN ExecutionPoll; // Available from v2.5
#endif
#endif

} QUIC_API_TABLE;

#define QUIC_API_VERSION_1 1 // Not supported any more
Expand Down
52 changes: 52 additions & 0 deletions src/inc/msquic_posix.h
Original file line number Diff line number Diff line change
Expand Up @@ -515,6 +515,58 @@ QuicAddrToString(
return TRUE;
}

//
// Event Queue Abstraction
//

#if __linux__ // epoll

#include <sys/epoll.h>
#include <sys/eventfd.h>

typedef int QUIC_EVENTQ;

typedef struct epoll_event QUIC_CQE;

typedef
void
(QUIC_EVENT_COMPLETION)(
_In_ QUIC_CQE* Cqe
);
typedef QUIC_EVENT_COMPLETION *QUIC_EVENT_COMPLETION_HANDLER;

typedef struct QUIC_SQE {
int fd;
QUIC_EVENT_COMPLETION_HANDLER Completion;
} QUIC_SQE;

#elif __APPLE__ || __FreeBSD__ // kqueue

#include <sys/event.h>
#include <fcntl.h>

typedef int QUIC_EVENTQ;

typedef struct kevent QUIC_CQE;

typedef
void
(QUIC_EVENT_COMPLETION)(
_In_ QUIC_CQE* Cqe
);
typedef QUIC_EVENT_COMPLETION *QUIC_EVENT_COMPLETION_HANDLER;

typedef struct QUIC_SQE {
uintptr_t Handle;
QUIC_EVENT_COMPLETION_HANDLER Completion;
} QUIC_SQE;

#else

#error Unsupported Platform

#endif

#if defined(__cplusplus)
}
#endif
Expand Down
24 changes: 24 additions & 0 deletions src/inc/msquic_winuser.h
Original file line number Diff line number Diff line change
Expand Up @@ -373,4 +373,28 @@ QuicAddrToString(

#endif // WINAPI_FAMILY != WINAPI_FAMILY_GAMES

//
// Event Queue Abstraction
//

typedef HANDLE QUIC_EVENTQ;

typedef OVERLAPPED_ENTRY QUIC_CQE;

typedef
_IRQL_requires_max_(PASSIVE_LEVEL)
void
(QUIC_EVENT_COMPLETION)(
_In_ QUIC_CQE* Cqe
);
typedef QUIC_EVENT_COMPLETION *QUIC_EVENT_COMPLETION_HANDLER;

typedef struct QUIC_SQE {
OVERLAPPED Overlapped;
QUIC_EVENT_COMPLETION_HANDLER Completion;
#if DEBUG
BOOLEAN IsQueued; // Debug flag to catch double queueing.
#endif
} QUIC_SQE;

#endif // _MSQUIC_WINUSER_
5 changes: 5 additions & 0 deletions src/tools/execution/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Copyright (c) Microsoft Corporation.
# Licensed under the MIT License.

add_quic_tool(quicexecution execution_windows.cpp)
quic_tool_warnings(quicexecution)
Loading
Loading