Skip to content

MessageActionItem should permit additional fields #411

Open
@nemethf

Description

@nemethf

Although the LSP specification does not define it explicitly, from the definition of ShowMessageRequestClientCapabilities it follows that MessageActionItem can have additional fields:

	messageActionItem?: {
		/**
		 * Whether the client supports additional attributes which
		 * are preserved and sent back to the server in the
		 * request's response.
		 */
		additionalPropertiesSupport?: boolean;
	};

However, lsprotocol does not permit this:

    print(types.MessageActionItem(title="title", asdf="asdf"))
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: MessageActionItem.__init__() got an unexpected keyword argument 'asdf'

(See the pygls issue)

Thanks

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable buglsp-update(For automation) marks that LSP spec requires updateunder-discussionIssue is under discussion for relevance, priority, approach

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions