Consolidate Standalone and Cluster Snapshot Metadata #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vazois
force-pushed
the
vazois/checkpoint-upgrade
branch
7 times, most recently
from
1b4acb2 to
89c161d
Compare
badrishc
reviewed
Apr 3, 2025
| @@ -232,13 +227,15 @@ public byte[] GetIndexCheckpointMetadata(Guid indexToken) | |||
| } | |||
|
|
|||
| /// <inheritdoc /> | |||
| public virtual unsafe void CommitLogCheckpoint(Guid logToken, byte[] commitMetadata) | |||
| public virtual unsafe void CommitLogCheckpoint(Guid logToken, HybridLogRecoveryInfo hlri) | |||
There was a problem hiding this comment.
HybridLogRecoveryInfo is an internal detail of Tsavorite that ideally should not be visible to plugin API. Instead Tsavorite interacts with the checkpoint plugin with two APIs:
byte[] CheckpointCookieState()void RecoverCookieState(byte[] cookie)
During checkpoint, it uses #1 to get the cookie to add to HLRI. During recovery, it uses #2 to tell the plugin what the recovered cookie is.
vazois
force-pushed
the
vazois/checkpoint-upgrade
branch
from
5e993ff to
9d76661
Compare
vazois
force-pushed
the
vazois/checkpoint-upgrade
branch
from
9d76661 to
3ee8c69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the standalone and cluster snapshot metadata format by making the user cookie part of HybridLogRecoveryInfo. This way on recovery the cookie is either deserialized or set to null and ignored if not needed.