Skip to content

fix(merge-styles): keep same type output for DeepPartialV2 to match original DeepPartial #31856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jun 28, 2024

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone Jun 28, 2024
@Hotell Hotell changed the title Fix/v8/improve infinite type issues v2 fix(merge-styles): keep same type output for DeepPartialV2 to match original DeepPartial Jun 28, 2024
@Hotell Hotell added the Fluent UI react (v8) Issues about @fluentui/react (v8) label Jun 28, 2024
@fabricteam
Copy link
Collaborator

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 627 638 5000
Breadcrumb mount 1691 1688 1000
Checkbox mount 1716 1744 5000
CheckboxBase mount 1493 1491 5000
ChoiceGroup mount 2988 2978 5000
ComboBox mount 684 688 1000
CommandBar mount 6537 6511 1000
ContextualMenu mount 12897 12832 1000
DefaultButton mount 818 788 5000
DetailsRow mount 2227 2292 5000
DetailsRowFast mount 2237 2218 5000
DetailsRowNoStyles mount 2071 2030 5000
Dialog mount 2706 2776 1000
DocumentCardTitle mount 241 227 1000
Dropdown mount 2007 2037 5000
FocusTrapZone mount 1133 1148 5000
FocusZone mount 1107 1092 5000
GroupedList mount 41990 42436 2
GroupedList virtual-rerender 18078 20212 2
GroupedList virtual-rerender-with-unmount 51296 51541 2
GroupedListV2 mount 233 228 2
GroupedListV2 virtual-rerender 204 213 2
GroupedListV2 virtual-rerender-with-unmount 240 234 2
IconButton mount 1122 1160 5000
Label mount 355 342 5000
Layer mount 2730 2750 5000
Link mount 406 409 5000
MenuButton mount 985 1022 5000
MessageBar mount 21263 21265 5000
Nav mount 2106 2032 1000
OverflowSet mount 808 818 5000
Panel mount 1815 1863 1000
Persona mount 750 745 1000
Pivot mount 928 913 1000
PrimaryButton mount 940 931 5000
Rating mount 4750 4677 5000
SearchBox mount 917 927 5000
Shimmer mount 1913 1882 5000
Slider mount 1353 1297 5000
SpinButton mount 3065 3001 5000
Spinner mount 398 402 5000
SplitButton mount 1871 1874 5000
Stack mount 420 420 5000
StackWithIntrinsicChildren mount 892 888 5000
StackWithTextChildren mount 2801 2781 5000
SwatchColorPicker mount 6462 6437 5000
TagPicker mount 1440 1461 5000
Text mount 387 386 5000
TextField mount 939 948 5000
ThemeProvider mount 870 870 5000
ThemeProvider virtual-rerender 603 578 5000
ThemeProvider virtual-rerender-with-unmount 1330 1341 5000
Toggle mount 617 617 5000
buttonNative mount 200 203 5000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react (v8) Issues about @fluentui/react (v8)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The latest version of @fluentui/merge-styles package is breaking.
2 participants