Skip to content

Add a RenderableFASTElement and default shadow options #7126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented May 29, 2025

Pull Request

📖 Description

This change:

  • Requires that using @microsoft/fast-html rendered markup include hydratable markup.
  • Adds default shadowOptions so they do not need to be passed
  • Adds a RenderableFASTElement export which will automatically add and remove the defer-hydration attributes

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu requested a review from mohamedmansour May 29, 2025 23:22
@janechu janechu merged commit 9b13225 into main May 30, 2025
7 of 8 checks passed
@janechu janechu deleted the users/janechu/add-default-options-for-elements-and-remove-defer-hydration-by-default branch May 30, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants