Fix f-template children directive flaky test #7107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdholt
previously approved these changes
Apr 14, 2025
janechu
force-pushed
the
users/janechu/fix-intermittent-test-failure
branch
2 times, most recently
from
0a2c36d to
7ebaeb2
Compare
janechu
force-pushed
the
users/janechu/fix-intermittent-test-failure
branch
4 times, most recently
from
9675328 to
f0a61e8
Compare
janechu
force-pushed
the
users/janechu/fix-intermittent-test-failure
branch
from
f0a61e8 to
1ec1918
Compare
janechu
force-pushed
the
users/janechu/fix-intermittent-test-failure
branch
from
925e307 to
68a78de
Compare
chrisdholt
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Fixes a flaky test in the children directive in
@microsoft/fast-html.✅ Checklist
General
$ npm run change