-
Notifications
You must be signed in to change notification settings - Fork 597
vNext: update components to extend FoundationElement #4570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chrisdholt
merged 46 commits into
features/design-system-vNext
from
users/chhol/add-foundation-element-support
Apr 20, 2021
Merged
Changes from all commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
28a0ffd
support foundation element on accordion and accordion item
chrisdholt c303614
update anchor to use foundation element
chrisdholt f4b60b6
update AnchoredRegion to extend FoundationElement
chrisdholt ee1faf5
update Badge to extend FoundationElement
chrisdholt 1df5ee1
update breadcrumb and breadcrumb item to extend FoundationElement
chrisdholt a609ea0
update Button to extend FoundationElement
chrisdholt deb09be
update checkbox to extend from FoundationElement
chrisdholt 2361b0a
update Dialog to extend FoundationElement
chrisdholt aa005e4
update disclosure to extend FoundationElement
chrisdholt 5972cb7
update divider to extend FoundationElement
chrisdholt e6f3f73
update Flipper to extend FoundationElement
chrisdholt 333cecc
update horizontal scroll to extend FoundationElement
chrisdholt ddf9ff9
update Listbox and ListboxOption to extend FoundationElement
chrisdholt 02cbfcf
update combobox to extend FoundationElement
chrisdholt 536387d
update select to extend combobox and update tests
chrisdholt 1c6f1d6
fix listbox option styles and export
chrisdholt 270eb3e
update tests (wip)
chrisdholt 65272f2
update Menu and MenuItem to extend FoundationElement
chrisdholt 7494984
update number field to extend FoundationElement
chrisdholt a081717
update base name values
chrisdholt 63adf59
fix: prevent the mixin helper from copying over constructor properties
2161262
feat: fixture ergonomic improvements for foundation elements
c4d22e8
test: fix Anchor and associated unit tests based on new system
b6a43f5
remove incorrect tagFor usage
chrisdholt 55708e2
update radio and radiogroup
chrisdholt 118fe6c
update skeleton
chrisdholt 8ce6c69
update slider and slider label
chrisdholt 85d6ec9
update switch
chrisdholt cc092cc
update tabs et all to use FoundationElement
chrisdholt a89446d
update text area and text field to use foundation el
chrisdholt 628ec9b
Update tooltip to use FoundationElement
chrisdholt 8244a97
update tests and tree item and view
chrisdholt a97c0a3
remove website from lerna packages in favor of npm registry to prevenβ¦
chrisdholt ba42bc0
update progress and progress ring to use Foundation element
chrisdholt 40fe7f7
fixing the tests
chrisdholt eac1189
feat: enable fixtures to handle N foundation elements and custom system
390520f
fixing tests!
chrisdholt 5aa218a
Change files
chrisdholt cba6989
fix errors in fast-website
chrisdholt c782af1
update typings for explorer
chrisdholt dbdef28
update naming convention to lowercase fast
chrisdholt 856974d
update imports for sites
chrisdholt 2fab56a
Change files
chrisdholt 48d9077
update template names to lowercase
chrisdholt f3b18c0
update style casing and apply updates to component registries
chrisdholt 3695a75
update tsdoc links for templates
chrisdholt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@microsoft-fast-components-a2550851-d95a-44e8-b894-b6522374a1f3.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "major", | ||
"comment": "update components to extend FoundationElement", | ||
"packageName": "@microsoft/fast-components", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
7 changes: 7 additions & 0 deletions
7
change/@microsoft-fast-foundation-a1f17588-3819-4e5d-bd7b-0551b59828a9.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "major", | ||
"comment": "update components to extend FoundationElement", | ||
"packageName": "@microsoft/fast-foundation", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
7 changes: 7 additions & 0 deletions
7
change/@microsoft-fast-tooling-react-f402f65f-d3f7-4bd8-be9b-6b6e55c2a7ec.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "none", | ||
"comment": "update fast-tooling references to web components", | ||
"packageName": "@microsoft/fast-tooling-react", | ||
"email": "[email protected]", | ||
"dependentChangeType": "none" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
791 changes: 578 additions & 213 deletions
791
packages/web-components/fast-components/docs/api-report.md
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 6 additions & 8 deletions
14
packages/web-components/fast-components/src/accordion-item/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 6 additions & 8 deletions
14
packages/web-components/fast-components/src/accordion/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
packages/web-components/fast-components/src/anchored-region/anchored-region.styles.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 6 additions & 8 deletions
14
packages/web-components/fast-components/src/anchored-region/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll probably want to change the comments on these since this is not exporting an element but exporting a factory for a component registration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EisenbergEffect @nicholasrice thoughts on the comment syntax and what we should include for these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicholasrice How should we handle the comments in this case? We probably needs a new comment for the function that says something like "Creates a component registration for
fast-accordion-item
usable with theDesignSystem
." Thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that works, but I'd make sure that the
DesignSystem
reference is an{@link @micorosoft/fast-foundation:DesignSystem}
so that our docs are referential. Or perhaps we have a link to a new tutorial-like section on how to use these definitions. Maybe both?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving these for a follow-up PR - but happy to make the updates