Skip to content

fix - Unsupported class file for the build action class #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

jdneo
Copy link
Member

@jdneo jdneo commented Jul 10, 2024

  • Move the GetSourceSetsAction class to the model module, to ensure that the GetSourceSetsAction class is compiled on level 1.8.
  • Set the required properties to the BuildActionExecuter.

fix #169

- Move the GetSourceSetsAction class to the model module, to ensure that
  the GetSourceSetsAction class is compiled on level 1.8.
- Set the required properties to the BuildActionExecuter.
@jdneo jdneo added this to the 0.3.0 milestone Jul 10, 2024
@jdneo jdneo added the bug Something isn't working label Jul 10, 2024
@jdneo jdneo requested a review from testforstephen July 10, 2024 07:24
@jdneo
Copy link
Member Author

jdneo commented Jul 10, 2024

// cc @Tanish-Ranjan, @Arthurm1

@Arthurm1
Copy link
Contributor

LGTM - makes sense to have the action in the Model project. I'd possibly go further and set the java version for server and plugin to 8 as well since the 17 features are hardly used and then more JDK versions are supported, but it's not for this PR.

@jdneo
Copy link
Member Author

jdneo commented Jul 10, 2024

I'd possibly go further and set the java version for server and plugin to 8 as well

the plugin is already 8 now: https://github.com/microsoft/build-server-for-gradle/blob/develop/plugin/build.gradle#L19. Server is now on 17. Yes making it on 8 will expand the usage. But some refactoring needs to be done. I can do that in another PR.

@Tanish-Ranjan
Copy link
Contributor

I have a different thought on this. The Model module only contains model classes which are used by Plugin and Server. It made the most sense for me to have the BuildAction in the Server functionality vise, although as you pointed out, we have a slight catch, that the BuildActions are executed within the Gradle Daemon.

So, I would add this to changes:

  • renaming the Model module to Internal (Something being used internally by both Plugin and Server) as it is no longer dedicated for models only.

@jdneo
Copy link
Member Author

jdneo commented Jul 10, 2024

@Tanish-Ranjan We can put it a debt. I'll discuss this with Donat to see what's the best answer.

For now, maybe we can merge this change first and release an updat. (I observed this problem because I saw the import success rate drop down from the BI)

@jdneo jdneo merged commit 0fe867f into develop Jul 11, 2024
4 checks passed
@jdneo jdneo deleted the cs/build-action branch July 11, 2024 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The compile of build action
4 participants