Add more error reporting for getGradleSourceSets failure #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdneo
reviewed
Apr 24, 2024
| } catch (GradleConnectionException | IllegalStateException e) { | ||
| summary = e.getMessage(); | ||
| } catch (GradleConnectionException | IllegalStateException | IOException e) { | ||
| summary = e.getMessage() + "\n" + errorOut.toString(); |
There was a problem hiding this comment.
Let's check if errorOut is empty or not before appending to the summary text.
Arthurm1
force-pushed
the
stderr_reporting
branch
from
98fb990 to
c1fc475
Compare
|
Thank you @Arthurm1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes
stderrback if retrieving source sets fails. Before there sometimes wasn't enough information to diagnose.