add message checking to integration tests

[Arthurm1]

Currently the integration tests only handle direct replies to BSP messages e.g. workspace/buildTargets returns WorkspaceBuildTargetsResult

This PR allows monitoring of async messages e.g. build/taskProgress and adds tests for these.

It's the first step in testing progress reports per build target and eventually diagnostic reports.

It also gets rid of the global Launcher.client which I think is a good thing.

Also fixed: the onBuildTaskProgress notification has a compile-task data kind so data must contain a CompileTask

[jdneo]

Had a quick look and the idea looks good to me.

Could you please resolve the conflict?

[Arthurm1]

@jdneo Done

[Arthurm1]

rebased

[jdneo]

LGTM

[jdneo]

Thank you @Arthurm1!

[jdneo]

@Arthurm1 Does this case pass on your side? Due to the current implementation at:

build-server-for-gradle/server/src/main/java/com/microsoft/java/bs/core/internal/gradle/GradleApiConnector.java

Lines 121 to 126 in 59b80ec

	// Note: this might be anti-sepc, because the spec limits that one compile task report
	// can only have one build target id. While we aggregate all compile related tasks into one
	// Gradle call for the perf consideration. So, the build target id passed into the reporter
	// is not accurate.
	TaskProgressReporter reporter = new TaskProgressReporter(
	new CompileProgressReporter(client, btIds.iterator().next()));

, it should fail.

It fails on my machine, but I have no idea why it passes in GitHub Actions.

[Arthurm1]

@jdneo Yes it passes on mine. What line does it fail on - 324? The messages I have at that point are...

It's possible you have additional messages. I noticed that the CompletableFuture.runAsync(this::reloadWorkspace); triggered after a compile will cause more messages to be sent to the client but that's normally too slow to register. I have fix for this and can submit a PR, but it's only ever happened to me when I've sat on a breakpoint for a while.

[jdneo]

I suspect this limitation causes the failure:

Target id for both main and test are sent to be compiled, and the task classes and testClasses are executed in one invocation. But because of

build-server-for-gradle/server/src/main/java/com/microsoft/java/bs/core/internal/gradle/GradleApiConnector.java

Line 126 in 59b80ec

new CompileProgressReporter(client, btIds.iterator().next()));

only main target id is set to the compile reporter, which fails line 326?

[Arthurm1]

@jdneo This makes sense - it could be failing on your machine due to message ordering differences. I've finished off #116 which should fix this if you'd like to review it. It reports on progress-per-target rather than just reporting everything on the first target.

[jdneo]

Cool! We can eliminate a protocol violation then. I'll review it these days. Thank you!