Shift sourceset population out of buildInitialize #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arthurm1
force-pushed
the
delay_sourceset_retrieval
branch
from
2ee41fa to
3181d79
Compare
|
@jdneo rebased |
|
Thank you @Arthurm1 |
jdneo
added
the
engineering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metals (BSP client) expects a prompt response to
build/initializeand if it doesn't get one within 30 seconds it assumes the build server has not started correctly and so attempts to restart it.Large projects take longer than this because the sourceset population takes a long time.
This shifts the population of sourcesets away from
build/initializeand intoworkspace/buildTargetsIt also shifts the responsibility of handling
workspace/reloadaway fromLifecycleServiceand intoBuildTargetService. TheLifecycleServicecode was similar to thatRefetchBuildTargetTaskso this allows doing away withRefetchBuildTargetTaskand also means that any call toworkspace/reloadwill cause abuildTarget/didChangeevent if the workspace has changed - which wasn't the case before.